Re: Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page

2016-07-19 Thread Richard Zang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50165/#review142796
---


Ship it!




Ship It!

- Richard Zang


On July 18, 2016, 10:20 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50165/
> ---
> 
> (Updated July 18, 2016, 10:20 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> # Go to SelectVersion page
> # Clear any input with Base URL (for ex. ubuntu14)
> # Click on next button
> 
> Expected: input has now red borders and warning message appears below 
> "Attention: All repo URLs are required before you can proceed."
> 
> Actually: Next button became to disabled state. Next page wasn't loaded.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/installer.js 037e555 
>   ambari-web/app/models/operating_system.js c2588fe 
> 
> Diff: https://reviews.apache.org/r/50165/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 29285 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>



Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page

2016-07-18 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50165/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

STR:
# Go to SelectVersion page
# Clear any input with Base URL (for ex. ubuntu14)
# Click on next button

Expected: input has now red borders and warning message appears below 
"Attention: All repo URLs are required before you can proceed."

Actually: Next button became to disabled state. Next page wasn't loaded.


Diffs
-

  ambari-web/app/controllers/installer.js 037e555 
  ambari-web/app/models/operating_system.js c2588fe 

Diff: https://reviews.apache.org/r/50165/diff/


Testing
---

Local ambari-web test passed.
29285 tests complete (25 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang