Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-20 Thread Dmytro Grinenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142930
---


Ship it!




Ship It!

- Dmytro Grinenko


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-19 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142903
---


Ship it!




Ship It!

- Nahappan Somasundaram


On July 19, 2016, 7:01 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 19, 2016, 7:01 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-19 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142896
---


Ship it!




Ship It!

- Swapan Shridhar


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-19 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142890
---


Ship it!




Ship It!

- Sumit Mohanty


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-19 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142889
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
258)


Is it ok to store it as " " (with one space) when ATLAS is not present?


- Sumit Mohanty


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142888
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
237)


Java and Python logic are now the same and won't repeat the same value 
(unless it's already there more than once).



ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 (line 5919)


The diff tool did a really bad job at showing what I moved around. 
Basically, testAtlasHiveProperties2 was moved here with the name 
testAtlasHivePropertiesWithHTTPS


- Alejandro Fernandez


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

2016-07-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/
---

Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
Mohanty, and Swapan Shridhar.


Bugs: AMBARI-17802
https://issues.apache.org/jira/browse/AMBARI-17802


Repository: ambari


Description
---

STR:
Install Ambari 2.4
Blueprint for HDP 2.5 with Atlas and Hive
Because both Blueprints and Stack Advisor have code to append 
"org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
config, the value appears twice.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 36cea56 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
e1bedb7 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 268bc29 

Diff: https://reviews.apache.org/r/50219/diff/


Testing
---

Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared only 
once.

Ran unit tests in BlueprintConfigurationProcessorTest.java

Python unit tests passed
--
Total run:1020
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez