Re: Review Request 50220: AMBARI-17724 AMS Storm sink: Set metrics filter to reduce large amount of built-in Storm metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50220/#review142965 --- Ship it! Ship It! - Aravindan Vijayan On July 20, 2016, 3:49 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50220/ > --- > > (Updated July 20, 2016, 3:49 a.m.) > > > Review request for Ambari, Prajwal Rao and Sriharsha Chintalapani. > > > Bugs: AMBARI-17724 > https://issues.apache.org/jira/browse/AMBARI-17724 > > > Repository: ambari > > > Description > --- > > Since Storm built-in metrics are provided to each task, topology with high > parallelism incurs lots of metrics pushed to AMS. > > Since we intend to provide Storm dashboards with AMS (working in progress), > we can filter out metrics not used for dashboards to reduce overall metrics > count. > > The parameters I'm adding are just ignored from Storm side if Storm doesn't > support that parameters. So it could work well with previous version of Storm. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml > b4350fc > > Diff: https://reviews.apache.org/r/50220/diff/ > > > Testing > --- > > Tested manually with Storm 1.1.0 SNAPSHOT and Ambari branch 2.4. > > > Thanks, > > Jungtaek Lim > >
Re: Review Request 50220: AMBARI-17724 AMS Storm sink: Set metrics filter to reduce large amount of built-in Storm metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50220/#review142954 --- Ship it! Ship It! - Sriharsha Chintalapani On July 20, 2016, 3:49 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50220/ > --- > > (Updated July 20, 2016, 3:49 a.m.) > > > Review request for Ambari, Prajwal Rao and Sriharsha Chintalapani. > > > Bugs: AMBARI-17724 > https://issues.apache.org/jira/browse/AMBARI-17724 > > > Repository: ambari > > > Description > --- > > Since Storm built-in metrics are provided to each task, topology with high > parallelism incurs lots of metrics pushed to AMS. > > Since we intend to provide Storm dashboards with AMS (working in progress), > we can filter out metrics not used for dashboards to reduce overall metrics > count. > > The parameters I'm adding are just ignored from Storm side if Storm doesn't > support that parameters. So it could work well with previous version of Storm. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml > b4350fc > > Diff: https://reviews.apache.org/r/50220/diff/ > > > Testing > --- > > Tested manually with Storm 1.1.0 SNAPSHOT and Ambari branch 2.4. > > > Thanks, > > Jungtaek Lim > >
Review Request 50220: AMBARI-17724 AMS Storm sink: Set metrics filter to reduce large amount of built-in Storm metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50220/ --- Review request for Ambari, Prajwal Rao and Sriharsha Chintalapani. Bugs: AMBARI-17724 https://issues.apache.org/jira/browse/AMBARI-17724 Repository: ambari Description --- Since Storm built-in metrics are provided to each task, topology with high parallelism incurs lots of metrics pushed to AMS. Since we intend to provide Storm dashboards with AMS (working in progress), we can filter out metrics not used for dashboards to reduce overall metrics count. The parameters I'm adding are just ignored from Storm side if Storm doesn't support that parameters. So it could work well with previous version of Storm. Diffs - ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml b4350fc Diff: https://reviews.apache.org/r/50220/diff/ Testing --- Tested manually with Storm 1.1.0 SNAPSHOT and Ambari branch 2.4. Thanks, Jungtaek Lim
