Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/#review143137
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 21, 2016, 8:29 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50256/
> ---
> 
> (Updated July 21, 2016, 8:29 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17798
> https://issues.apache.org/jira/browse/AMBARI-17798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for fixing oozie admin user for Falcon when doing upgrades
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a19 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 315020b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50256/diff/
> 
> 
> Testing
> ---
> 
> Added UT and successfully executed it
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/
---

(Updated July 21, 2016, 1:29 p.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Removed unneded file.   Also fixed the base stack advisor to have logger 
statements instead of prints and cleaned up a bit


Bugs: AMBARI-17798
https://issues.apache.org/jira/browse/AMBARI-17798


Repository: ambari


Description
---

Support for fixing oozie admin user for Falcon when doing upgrades


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7be5a19 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
7f277fb 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 2daa9b8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
43c6265 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
315020b 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50256/diff/


Testing
---

Added UT and successfully executed it


Thanks,

Venkat Ranganathan

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/#review143121
---




ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml (line 
744)


Why was this necessary in HDP 2.4 -> 2.4*?


- Alejandro Fernandez


On July 20, 2016, 6:46 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50256/
> ---
> 
> (Updated July 20, 2016, 6:46 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17798
> https://issues.apache.org/jira/browse/AMBARI-17798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for fixing oozie admin user for Falcon when doing upgrades
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  a7383a2 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 85ffb8c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  00dbaa7 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 78d22ab 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 68e8fc2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50256/diff/
> 
> 
> Testing
> ---
> 
> Added UT and successfully executed it
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/
---

(Updated July 20, 2016, 11:46 a.m.)


Review request for Ambari and Alejandro Fernandez.


Changes
---

Fixed the index check


Bugs: AMBARI-17798
https://issues.apache.org/jira/browse/AMBARI-17798


Repository: ambari


Description
---

Support for fixing oozie admin user for Falcon when doing upgrades


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 a7383a2 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
85ffb8c 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 00dbaa7 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
78d22ab 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
68e8fc2 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50256/diff/


Testing
---

Added UT and successfully executed it


Thanks,

Venkat Ranganathan

Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/#review142984
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
 (line 79)


>= 0


- Alejandro Fernandez


On July 20, 2016, 6:33 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50256/
> ---
> 
> (Updated July 20, 2016, 6:33 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-17798
> https://issues.apache.org/jira/browse/AMBARI-17798
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support for fixing oozie admin user for Falcon when doing upgrades
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  a7383a2 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 85ffb8c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  00dbaa7 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 78d22ab 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 68e8fc2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50256/diff/
> 
> 
> Testing
> ---
> 
> Added UT and successfully executed it
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50256/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-17798
https://issues.apache.org/jira/browse/AMBARI-17798


Repository: ambari


Description
---

Support for fixing oozie admin user for Falcon when doing upgrades


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 a7383a2 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
85ffb8c 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 00dbaa7 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
78d22ab 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
68e8fc2 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50256/diff/


Testing
---

Added UT and successfully executed it


Thanks,

Venkat Ranganathan