Re: Review Request 50278: AMBARI-17825. Fix the empty value which may get passed back from 'get_llap_cap_percent_slider' fn.

2016-07-20 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50278/#review143042
---


Ship it!




Ship It!

- Sumit Mohanty


On July 21, 2016, 1:42 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50278/
> ---
> 
> (Updated July 21, 2016, 1:42 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17825
> https://issues.apache.org/jira/browse/AMBARI-17825
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - The fn . get_llap_cap_percent_slider() may return None if the bounded 
> conditions are not met while fetching 'lllap_queue_capacity'.
> - Also, had issue with typecasting from string to int.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 315020b 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 7c8a6e7 
> 
> Diff: https://reviews.apache.org/r/50278/diff/
> 
> 
> Testing
> ---
> 
> Modified Python UT to test it.
> - Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>



Review Request 50278: AMBARI-17825. Fix the empty value which may get passed back from 'get_llap_cap_percent_slider' fn.

2016-07-20 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50278/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17825
https://issues.apache.org/jira/browse/AMBARI-17825


Repository: ambari


Description
---

- The fn . get_llap_cap_percent_slider() may return None if the bounded 
conditions are not met while fetching 'lllap_queue_capacity'.
- Also, had issue with typecasting from string to int.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
315020b 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 7c8a6e7 

Diff: https://reviews.apache.org/r/50278/diff/


Testing
---

Modified Python UT to test it.
- Python UT passes.


Thanks,

Swapan Shridhar