Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Venkat Ranganathan]

> On July 21, 2016, 8:56 a.m., Venkat Ranganathan wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 331
> > 
> >
> > Do we need this.  Isn't OOZIE added in HDP21StackAdvisor whose 
> > dictionary is merged in succeeding child classes?

I see that you are adding to child configuration.  I fixed the oozie 
recommender config.  Sorry about that.   Ranger does not need to send Oozie 
config.


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143089
---


On July 21, 2016, 3:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 3:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143114
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
276)


I saw the same thing during one of my in-progress patches. Thanks.


- Alejandro Fernandez


On July 21, 2016, 10:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 10:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143111
---


Ship it!




Ship It!

- Jayush Luniya


On July 21, 2016, 10:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 10:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/#review143089
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
331)


Do we need this.  Isn't OOZIE added in HDP21StackAdvisor whose dictionary 
is merged in succeeding child classes?


- Venkat Ranganathan


On July 21, 2016, 3:19 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50287/
> ---
> 
> (Updated July 21, 2016, 3:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17830
> https://issues.apache.org/jira/browse/AMBARI-17830
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by: 
> org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: 
> Stack Advisor reported an error: KeyError: 'atlas.server.https.port'
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 19753e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 5e380d8 
> 
> Diff: https://reviews.apache.org/r/50287/diff/
> 
> 
> Testing
> ---
> 
> Tested Atlas installation
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50287/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17830
https://issues.apache.org/jira/browse/AMBARI-17830


Repository: ambari


Description
---

Caused by: 
org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: Stack 
Advisor reported an error: KeyError: 'atlas.server.https.port'


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
19753e5 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
5e380d8 

Diff: https://reviews.apache.org/r/50287/diff/


Testing
---

Tested Atlas installation


Thanks,

Mugdha Varadkar