Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-08-05 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review144922
---



committed to trunk: c63b34cc2d02d58e4b76ac29c50e812a10eb3e6c
now you can submit this review request (possibly re-open it for branch-2.5 
later)

- Oliver Szabo


On Aug. 1, 2016, 1:10 p.m., Hemanth Yamijala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> ---
> 
> (Updated Aug. 1, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, 
> and Oliver Szabo.
> 
> 
> Bugs: AMBARI-17788
> https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> ---
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-08-01 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review144332
---


Ship it!




Ship It!

- Oliver Szabo


On Aug. 1, 2016, 1:10 p.m., Hemanth Yamijala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> ---
> 
> (Updated Aug. 1, 2016, 1:10 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Miklos Gergely, 
> and Oliver Szabo.
> 
> 
> Bugs: AMBARI-17788
> https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> ---
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-26 Thread Dharmesh Makwana 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review143489
---


Ship it!




Ship It!

- Dharmesh Makwana


On July 26, 2016, 5:55 a.m., Hemanth Yamijala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> ---
> 
> (Updated July 26, 2016, 5:55 a.m.)
> 
> 
> Review request for Ambari, Hayat Behlim and Dharmesh Makwana.
> 
> 
> Bugs: AMBARI-17788
> https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> ---
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-26 Thread Hayat Behlim 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review143486
---


Ship it!




Ship It!

- Hayat Behlim


On July 26, 2016, 5:55 a.m., Hemanth Yamijala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> ---
> 
> (Updated July 26, 2016, 5:55 a.m.)
> 
> 
> Review request for Ambari, Hayat Behlim and Dharmesh Makwana.
> 
> 
> Bugs: AMBARI-17788
> https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> ---
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-25 Thread Hemanth Yamijala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/
---

(Updated July 26, 2016, 5:55 a.m.)


Review request for Ambari, Hayat Behlim and Dharmesh Makwana.


Changes
---

Missed moving a log line with the earlier change. Just updated that.


Bugs: AMBARI-17788
https://issues.apache.org/jira/browse/AMBARI-17788


Repository: ambari


Description
---

This patch extracts spooling functions outside OutputHDFSFile so that it can be 
used for AMBARI-17785. The patch allows callbacks to check the condition on 
which spool files should be rolled over and what to do on rollover.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 87cc0eb 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50297/diff/


Testing
---

* New unit tests.
* Have tested by installing new RPM on an existing Ambari installation and 
configuring the output for one of the services to write to HDFS. Tested that 
upload to HDFS, rollover is working correctly for this service.


Thanks,

Hemanth Yamijala

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-25 Thread Hemanth Yamijala 


> On July 25, 2016, 1:04 p.m., Hayat Behlim wrote:
> > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java,
> >  line 126
> > 
> >
> > I think just for sake of understanding initializeSpoolFile() will come 
> > after handleRollover method is invoked.

Thanks for taking a look, Hayat. I agree with your comment. Have swapped the 
order.


- Hemanth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review143372
---


On July 26, 2016, 5:46 a.m., Hemanth Yamijala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> ---
> 
> (Updated July 26, 2016, 5:46 a.m.)
> 
> 
> Review request for Ambari, Hayat Behlim and Dharmesh Makwana.
> 
> 
> Bugs: AMBARI-17788
> https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> ---
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-25 Thread Hemanth Yamijala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/
---

(Updated July 26, 2016, 5:46 a.m.)


Review request for Ambari, Hayat Behlim and Dharmesh Makwana.


Changes
---

Incorporated review comment from Hayat.


Bugs: AMBARI-17788
https://issues.apache.org/jira/browse/AMBARI-17788


Repository: ambari


Description
---

This patch extracts spooling functions outside OutputHDFSFile so that it can be 
used for AMBARI-17785. The patch allows callbacks to check the condition on 
which spool files should be rolled over and what to do on rollover.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 87cc0eb 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50297/diff/


Testing
---

* New unit tests.
* Have tested by installing new RPM on an existing Ambari installation and 
configuring the output for one of the services to write to HDFS. Tested that 
upload to HDFS, rollover is working correctly for this service.


Thanks,

Hemanth Yamijala

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-25 Thread Hayat Behlim 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/#review143372
---




ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
 (line 126)


I think just for sake of understanding initializeSpoolFile() will come 
after handleRollover method is invoked.


- Hayat Behlim


On July 25, 2016, 7:17 a.m., Hemanth Yamijala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50297/
> ---
> 
> (Updated July 25, 2016, 7:17 a.m.)
> 
> 
> Review request for Ambari, Hayat Behlim and Dharmesh Makwana.
> 
> 
> Bugs: AMBARI-17788
> https://issues.apache.org/jira/browse/AMBARI-17788
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch extracts spooling functions outside OutputHDFSFile so that it can 
> be used for AMBARI-17785. The patch allows callbacks to check the condition 
> on which spool files should be rolled over and what to do on rollover.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
>  87cc0eb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50297/diff/
> 
> 
> Testing
> ---
> 
> * New unit tests.
> * Have tested by installing new RPM on an existing Ambari installation and 
> configuring the output for one of the services to write to HDFS. Tested that 
> upload to HDFS, rollover is working correctly for this service.
> 
> 
> Thanks,
> 
> Hemanth Yamijala
> 
>

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-25 Thread Hemanth Yamijala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/
---

(Updated July 25, 2016, 7:17 a.m.)


Review request for Ambari, Hayat Behlim and Dharmesh Makwana.


Changes
---

Rebased to trunk after changes in AMBARI-17834


Bugs: AMBARI-17788
https://issues.apache.org/jira/browse/AMBARI-17788


Repository: ambari


Description
---

This patch extracts spooling functions outside OutputHDFSFile so that it can be 
used for AMBARI-17785. The patch allows callbacks to check the condition on 
which spool files should be rolled over and what to do on rollover.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 87cc0eb 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50297/diff/


Testing
---

* New unit tests.
* Have tested by installing new RPM on an existing Ambari installation and 
configuring the output for one of the services to write to HDFS. Tested that 
upload to HDFS, rollover is working correctly for this service.


Thanks,

Hemanth Yamijala

Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-21 Thread Hemanth Yamijala 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50297/
---

Review request for Ambari.


Bugs: AMBARI-17788
https://issues.apache.org/jira/browse/AMBARI-17788


Repository: ambari


Description
---

This patch extracts spooling functions outside OutputHDFSFile so that it can be 
used for AMBARI-17785. The patch allows callbacks to check the condition on 
which spool files should be rolled over and what to do on rollover.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputHDFSFile.java
 9272636 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpooler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerContext.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverCondition.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/spool/RolloverHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/spool/LogSpoolerTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50297/diff/


Testing
---

* New unit tests.
* Have tested by installing new RPM on an existing Ambari installation and 
configuring the output for one of the services to write to HDFS. Tested that 
upload to HDFS, rollover is working correctly for this service.


Thanks,

Hemanth Yamijala