Re: Review Request 50314: Show existing views under relevant service page as tabs

2016-07-22 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/#review143282
---


Ship it!




Ship It!

- Jaimin Jetly


On July 22, 2016, 8:28 p.m., Manasi Maheshwari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50314/
> ---
> 
> (Updated July 22, 2016, 8:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17824
> https://issues.apache.org/jira/browse/AMBARI-17824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following needs to be done as part of this work
> view instances needs to be shown under relevant service as tabs
> content of the view resources needs to be shown in iframe
> Quick links location needs to be adjusted so it does not collapse with view 
> tabs
> Left service menu on the service page needs to be removed to give more space 
> to view content
> Increase the span for the pages under service page for larger width
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 79493a1 
>   ambari-web/app/messages.js 24c9cfa 
>   ambari-web/app/models/stack_service.js 3e2d5b4 
>   ambari-web/app/routes/main.js ebf9cb3 
>   ambari-web/app/styles/application.less 200c7be 
>   ambari-web/app/templates/main/service/item.hbs 43fb3dd 
>   ambari-web/app/views.js 904edb7 
>   ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
>   ambari-web/app/views/main/dashboard.js 9694774 
>   ambari-web/app/views/main/service/item.js 02ac426 
>   ambari-web/app/views/main/views/details.js df1b19b 
> 
> Diff: https://reviews.apache.org/r/50314/diff/
> 
> 
> Testing
> ---
> 
> I verified that the patch accomplishes the tasks written in the description.
> Verified that unit test passes with the patch
> 29343 tests complete (26 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Manasi Maheshwari
> 
>

Re: Review Request 50314: Show existing views under relevant service page as tabs

2016-07-22 Thread Manasi Maheshwari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/
---

(Updated July 22, 2016, 8:28 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.


Changes
---

address last comments


Bugs: AMBARI-17824
https://issues.apache.org/jira/browse/AMBARI-17824


Repository: ambari


Description
---

Following needs to be done as part of this work
view instances needs to be shown under relevant service as tabs
content of the view resources needs to be shown in iframe
Quick links location needs to be adjusted so it does not collapse with view tabs
Left service menu on the service page needs to be removed to give more space to 
view content
Increase the span for the pages under service page for larger width


Diffs (updated)
-

  ambari-web/app/app.js 79493a1 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/models/stack_service.js 3e2d5b4 
  ambari-web/app/routes/main.js ebf9cb3 
  ambari-web/app/styles/application.less 200c7be 
  ambari-web/app/templates/main/service/item.hbs 43fb3dd 
  ambari-web/app/views.js 904edb7 
  ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
  ambari-web/app/views/main/dashboard.js 9694774 
  ambari-web/app/views/main/service/item.js 02ac426 
  ambari-web/app/views/main/views/details.js df1b19b 

Diff: https://reviews.apache.org/r/50314/diff/


Testing
---

I verified that the patch accomplishes the tasks written in the description.
Verified that unit test passes with the patch
29343 tests complete (26 seconds)
154 tests pending


Thanks,

Manasi Maheshwari

Re: Review Request 50314: Show existing views under relevant service page as tabs

2016-07-21 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/#review143159
---




ambari-web/app/app.js (lines 292 - 299)


Lets remove this code if it is not being used in the code



ambari-web/app/messages.js (lines 2860 - 2864)


Lets remove this line if its not being used.



ambari-web/app/views/main/dashboard.js (lines 42 - 47)


Lets revert this change if it was unintentional


- Jaimin Jetly


On July 21, 2016, 11:53 p.m., Manasi Maheshwari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50314/
> ---
> 
> (Updated July 21, 2016, 11:53 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17824
> https://issues.apache.org/jira/browse/AMBARI-17824
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following needs to be done as part of this work
> view instances needs to be shown under relevant service as tabs
> content of the view resources needs to be shown in iframe
> Quick links location needs to be adjusted so it does not collapse with view 
> tabs
> Left service menu on the service page needs to be removed to give more space 
> to view content
> Increase the span for the pages under service page for larger width
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
>  189daef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  74de530 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java 
> b9efd74 
>   ambari-web/app/app.js 79493a1 
>   ambari-web/app/controllers/main/charts/heatmap.js 73d1800 
>   ambari-web/app/messages.js 24c9cfa 
>   ambari-web/app/models.js e0168a2 
>   ambari-web/app/models/stack_service.js 3e2d5b4 
>   ambari-web/app/models/view_instance.js PRE-CREATION 
>   ambari-web/app/routes/main.js ebf9cb3 
>   ambari-web/app/routes/views.js 1d19279 
>   ambari-web/app/styles/application.less 200c7be 
>   ambari-web/app/templates/main/service.hbs 3a4f786 
>   ambari-web/app/templates/main/service/item.hbs 43fb3dd 
>   ambari-web/app/views.js 904edb7 
>   ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
>   ambari-web/app/views/main/dashboard.js 9694774 
>   ambari-web/app/views/main/service/info/menu.js 3533a72 
>   ambari-web/app/views/main/service/item.js 02ac426 
>   ambari-web/app/views/main/views/details.js df1b19b 
>   ambari-web/test/views/main/service/info/menu_test.js 5caa5b0 
> 
> Diff: https://reviews.apache.org/r/50314/diff/
> 
> 
> Testing
> ---
> 
> I verified that the patch accomplishes the tasks written in the description.
> Verified that unit test passes with the patch
> 29343 tests complete (26 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Manasi Maheshwari
> 
>

Re: Review Request 50314: Show existing views under relevant service page as tabs

2016-07-21 Thread Manasi Maheshwari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/
---

(Updated July 21, 2016, 11:53 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.


Changes
---

Deleted unnecessary array


Bugs: AMBARI-17824
https://issues.apache.org/jira/browse/AMBARI-17824


Repository: ambari


Description
---

Following needs to be done as part of this work
view instances needs to be shown under relevant service as tabs
content of the view resources needs to be shown in iframe
Quick links location needs to be adjusted so it does not collapse with view tabs
Left service menu on the service page needs to be removed to give more space to 
view content
Increase the span for the pages under service page for larger width


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
 189daef 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 74de530 
  ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java b9efd74 
  ambari-web/app/app.js 79493a1 
  ambari-web/app/controllers/main/charts/heatmap.js 73d1800 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/models.js e0168a2 
  ambari-web/app/models/stack_service.js 3e2d5b4 
  ambari-web/app/models/view_instance.js PRE-CREATION 
  ambari-web/app/routes/main.js ebf9cb3 
  ambari-web/app/routes/views.js 1d19279 
  ambari-web/app/styles/application.less 200c7be 
  ambari-web/app/templates/main/service.hbs 3a4f786 
  ambari-web/app/templates/main/service/item.hbs 43fb3dd 
  ambari-web/app/views.js 904edb7 
  ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
  ambari-web/app/views/main/dashboard.js 9694774 
  ambari-web/app/views/main/service/info/menu.js 3533a72 
  ambari-web/app/views/main/service/item.js 02ac426 
  ambari-web/app/views/main/views/details.js df1b19b 
  ambari-web/test/views/main/service/info/menu_test.js 5caa5b0 

Diff: https://reviews.apache.org/r/50314/diff/


Testing
---

I verified that the patch accomplishes the tasks written in the description.
Verified that unit test passes with the patch
29343 tests complete (26 seconds)
154 tests pending


Thanks,

Manasi Maheshwari

Review Request 50314: Show existing views under relevant service page as tabs

2016-07-21 Thread Manasi Maheshwari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50314/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-17824
https://issues.apache.org/jira/browse/AMBARI-17824


Repository: ambari


Description
---

Following needs to be done as part of this work
view instances needs to be shown under relevant service as tabs
content of the view resources needs to be shown in iframe
Quick links location needs to be adjusted so it does not collapse with view tabs
Left service menu on the service page needs to be removed to give more space to 
view content
Increase the span for the pages under service page for larger width


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java
 189daef 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
 74de530 
  ambari-views/src/main/java/org/apache/ambari/view/ViewDefinition.java b9efd74 
  ambari-web/app/app.js 79493a1 
  ambari-web/app/controllers/main/charts/heatmap.js 73d1800 
  ambari-web/app/messages.js 24c9cfa 
  ambari-web/app/models.js e0168a2 
  ambari-web/app/models/stack_service.js 3e2d5b4 
  ambari-web/app/models/view_instance.js PRE-CREATION 
  ambari-web/app/routes/main.js ebf9cb3 
  ambari-web/app/routes/views.js 1d19279 
  ambari-web/app/styles/application.less 200c7be 
  ambari-web/app/templates/main/service.hbs 3a4f786 
  ambari-web/app/templates/main/service/item.hbs 43fb3dd 
  ambari-web/app/views.js 904edb7 
  ambari-web/app/views/common/widget/heatmap_widget_view.js 6c74420 
  ambari-web/app/views/main/dashboard.js 9694774 
  ambari-web/app/views/main/service/info/menu.js 3533a72 
  ambari-web/app/views/main/service/item.js 02ac426 
  ambari-web/app/views/main/views/details.js df1b19b 
  ambari-web/test/views/main/service/info/menu_test.js 5caa5b0 

Diff: https://reviews.apache.org/r/50314/diff/


Testing
---

I verified that the patch accomplishes the tasks written in the description.
Verified that unit test passes with the patch
29343 tests complete (26 seconds)
154 tests pending


Thanks,

Manasi Maheshwari