Re: Review Request 50542: AMBARI-17936 Log search tab seems to be visible for all user roles

2016-07-28 Thread Alexandr Antonenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50542/#review143957
---


Ship it!




Ship It!

- Alexandr Antonenko


On Июль 27, 2016, 11:31 п.п., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50542/
> ---
> 
> (Updated Июль 27, 2016, 11:31 п.п.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Richard Zang, 
> Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17936
> https://issues.apache.org/jira/browse/AMBARI-17936
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log search tabs (in host details page) must be only visible for service admin 
> user and above. Right now it is visible to all roles including cluster user.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/host/menu.js 07d9def 
>   ambari-web/test/views/main/host/menu_test.js f7d35a4 
> 
> Diff: https://reviews.apache.org/r/50542/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 29414 tests complete (26 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>



Review Request 50542: AMBARI-17936 Log search tab seems to be visible for all user roles

2016-07-27 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50542/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Richard Zang, 
Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-17936
https://issues.apache.org/jira/browse/AMBARI-17936


Repository: ambari


Description
---

Log search tabs (in host details page) must be only visible for service admin 
user and above. Right now it is visible to all roles including cluster user.


Diffs
-

  ambari-web/app/views/main/host/menu.js 07d9def 
  ambari-web/test/views/main/host/menu_test.js f7d35a4 

Diff: https://reviews.apache.org/r/50542/diff/


Testing
---

Modified unit test.
Local ambari-web test passed.
29414 tests complete (26 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang