Re: Review Request 50946: YARN config to fetch new HDFS delegation tokens is not enabled

2016-08-10 Thread Robert Levas


> On Aug. 10, 2016, 2:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, 
> > line 697
> > 
> >
> > Rob - kerberos.json already has the spec to set the value to true. So 
> > the stack advisor changes should not be necessary.
> > 
> > I am happy to drop this patch unless you feel that the stack advisor is 
> > where we should keep the logic instead of kerberos.json.

I would eventually like to move all the configuration blocks from the Kerberos 
descriptor to the stack advisor.  Since the stack advisor is _smarter_ than the 
Kerberos descroptor logic, more flexibilty in setting properties can be 
utilized.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50946/#review145311
---


On Aug. 10, 2016, 2:18 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50946/
> ---
> 
> (Updated Aug. 10, 2016, 2:18 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-18096
> https://issues.apache.org/jira/browse/AMBARI-18096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Summarizing what we need to do in Ambari :
> 
> - yarn.resourcemanager.proxy-user-privileges.enabled = False by default.
> - If (security is ON and TDE is OFF) -> 
> yarn.resourcemanager.proxy-user-privileges.enabled = True
> - If TDE is ON -> yarn.resourcemanager.proxy-user-privileges.enabled = False
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 9a099c6 
> 
> Diff: https://reviews.apache.org/r/50946/diff/
> 
> 
> Testing
> ---
> 
> Manually ran all unit tests. Tested by patching a private cluster.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>



Re: Review Request 50946: YARN config to fetch new HDFS delegation tokens is not enabled

2016-08-10 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50946/#review145311
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
696)


Rob - kerberos.json already has the spec to set the value to true. So the 
stack advisor changes should not be necessary.

I am happy to drop this patch unless you feel that the stack advisor is 
where we should keep the logic instead of kerberos.json.


- Sumit Mohanty


On Aug. 10, 2016, 6:18 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50946/
> ---
> 
> (Updated Aug. 10, 2016, 6:18 a.m.)
> 
> 
> Review request for Ambari, Robert Levas and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-18096
> https://issues.apache.org/jira/browse/AMBARI-18096
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Summarizing what we need to do in Ambari :
> 
> - yarn.resourcemanager.proxy-user-privileges.enabled = False by default.
> - If (security is ON and TDE is OFF) -> 
> yarn.resourcemanager.proxy-user-privileges.enabled = True
> - If TDE is ON -> yarn.resourcemanager.proxy-user-privileges.enabled = False
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 9a099c6 
> 
> Diff: https://reviews.apache.org/r/50946/diff/
> 
> 
> Testing
> ---
> 
> Manually ran all unit tests. Tested by patching a private cluster.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>



Review Request 50946: YARN config to fetch new HDFS delegation tokens is not enabled

2016-08-10 Thread Sumit Mohanty

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50946/
---

Review request for Ambari, Robert Levas and Swapan Shridhar.


Bugs: AMBARI-18096
https://issues.apache.org/jira/browse/AMBARI-18096


Repository: ambari


Description
---

Summarizing what we need to do in Ambari :

- yarn.resourcemanager.proxy-user-privileges.enabled = False by default.
- If (security is ON and TDE is OFF) -> 
yarn.resourcemanager.proxy-user-privileges.enabled = True
- If TDE is ON -> yarn.resourcemanager.proxy-user-privileges.enabled = False


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
9a099c6 

Diff: https://reviews.apache.org/r/50946/diff/


Testing
---

Manually ran all unit tests. Tested by patching a private cluster.


Thanks,

Sumit Mohanty