Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-11 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/
---

(Updated Aug. 11, 2016, 11:36 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Updated code to use stack root instead of actual path.


Bugs: AMBARI-18099
https://issues.apache.org/jira/browse/AMBARI-18099


Repository: ambari


Description
---

Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
host and is SSL enabled


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
 1d1b0c2 

Diff: https://reviews.apache.org/r/50950/diff/


Testing
---

Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies are 
syncing in ssl enabled environment.
Also verified unit-tests.


Thanks,

Vishal Suvagia

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-11 Thread Vishal Suvagia 


> On Aug. 10, 2016, 9:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml,
> >  line 24
> > 
> >
> > Should not hardcode /usr/hdp
> > Instead, need to use {{stack_root}}

handled Alejandro's comments.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/#review145404
---


On Aug. 10, 2016, 6:56 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50950/
> ---
> 
> (Updated Aug. 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18099
> https://issues.apache.org/jira/browse/AMBARI-18099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
> host and is SSL enabled
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  715f2f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50950/diff/
> 
> 
> Testing
> ---
> 
> Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies 
> are syncing in ssl enabled environment.
> Also verified unit-tests.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/#review145404
---


Fix it, then Ship it!




Fix it and Ship it


ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
 (line 24)


Should not hardcode /usr/hdp
Instead, need to use {{stack_root}}


- Alejandro Fernandez


On Aug. 10, 2016, 6:56 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50950/
> ---
> 
> (Updated Aug. 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18099
> https://issues.apache.org/jira/browse/AMBARI-18099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
> host and is SSL enabled
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  715f2f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50950/diff/
> 
> 
> Testing
> ---
> 
> Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies 
> are syncing in ssl enabled environment.
> Also verified unit-tests.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/#review145402
---


Ship it!




Ship It!

- Jayush Luniya


On Aug. 10, 2016, 6:56 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50950/
> ---
> 
> (Updated Aug. 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18099
> https://issues.apache.org/jira/browse/AMBARI-18099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
> host and is SSL enabled
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  715f2f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50950/diff/
> 
> 
> Testing
> ---
> 
> Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies 
> are syncing in ssl enabled environment.
> Also verified unit-tests.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/#review145400
---


Ship it!




Ship It!

- Sumit Mohanty


On Aug. 10, 2016, 6:56 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50950/
> ---
> 
> (Updated Aug. 10, 2016, 6:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18099
> https://issues.apache.org/jira/browse/AMBARI-18099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
> host and is SSL enabled
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  715f2f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50950/diff/
> 
> 
> Testing
> ---
> 
> Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies 
> are syncing in ssl enabled environment.
> Also verified unit-tests.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/
---

(Updated Aug. 10, 2016, 6:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Added ranger-hive-security.xml for 2.5 stacks instead of existing 
ranger-hive-security.xml.


Bugs: AMBARI-18099
https://issues.apache.org/jira/browse/AMBARI-18099


Repository: ambari


Description
---

Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
host and is SSL enabled


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 715f2f5 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-security.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50950/diff/


Testing
---

Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies are 
syncing in ssl enabled environment.
Also verified unit-tests.


Thanks,

Vishal Suvagia

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/#review145358
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 (line 42)


Since hive interactive is available since 2.5, shouldnt this change be a 
part of HDP 2.5 ?


- Gautam Borad


On Aug. 10, 2016, 2:27 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50950/
> ---
> 
> (Updated Aug. 10, 2016, 2:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-18099
> https://issues.apache.org/jira/browse/AMBARI-18099
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
> host and is SSL enabled
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  715f2f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
>  ce4074a 
> 
> Diff: https://reviews.apache.org/r/50950/diff/
> 
> 
> Testing
> ---
> 
> Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies 
> are syncing in ssl enabled environment.
> Also verified unit-tests.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/
---

(Updated Aug. 10, 2016, 2:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-18099
https://issues.apache.org/jira/browse/AMBARI-18099


Repository: ambari


Description
---

Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
host and is SSL enabled


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 715f2f5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 ce4074a 

Diff: https://reviews.apache.org/r/50950/diff/


Testing
---

Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies are 
syncing in ssl enabled environment.
Also verified unit-tests.


Thanks,

Vishal Suvagia

Review Request 50950: AMBARI-18099 : Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate host.

2016-08-10 Thread Vishal Suvagia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50950/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-18099
https://issues.apache.org/jira/browse/AMBARI-18099


Repository: ambari


Description
---

Ranger policies not syncing when Hive-server-Hive2 is installed on a seperate 
host and is SSL enabled


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 715f2f5 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-security.xml
 ce4074a 

Diff: https://reviews.apache.org/r/50950/diff/


Testing
---

Verified: Hive-Server2 and Hive-Server-Hive2 are both working and policies are 
syncing in ssl enabled environment.
Also verified unit-tests.


Thanks,

Vishal Suvagia