Re: Review Request 50980: JBehave & Docker based integration test framework for Log Search

2016-08-16 Thread Miklos Gergely

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50980/#review145851
---


Ship it!




Ship It!

- Miklos Gergely


On Aug. 16, 2016, 9:26 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50980/
> ---
> 
> (Updated Aug. 16, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Robert 
> Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18076
> https://issues.apache.org/jira/browse/AMBARI-18076
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Docker based test framework for Log Search with JBehave.
> - define stories instead of writing code (for checking component logs are 
> parsed)
> - later add new steps (like using web driver to check to UI too)
> - useful to check integration tests after development to avoid regression 
> issues
> run it from ambari-logsearch folder: mvn clean integration-test 
> -Dit.skip=false
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 23790cd 
>   ambari-logsearch/ambari-logsearch-it/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-it/src/test/resources/log4j.properties 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
>  PRE-CREATION 
>   ambari-logsearch/pom.xml 0445c39 
> 
> Diff: https://reviews.apache.org/r/50980/diff/
> 
> 
> Testing
> ---
> 
> done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>



Re: Review Request 50980: JBehave & Docker based integration test framework for Log Search

2016-08-16 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50980/
---

(Updated Aug. 16, 2016, 9:26 a.m.)


Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Robert Nettleton, 
Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

add run command


Bugs: AMBARI-18076
https://issues.apache.org/jira/browse/AMBARI-18076


Repository: ambari


Description (updated)
---

Docker based test framework for Log Search with JBehave.
- define stories instead of writing code (for checking component logs are 
parsed)
- later add new steps (like using web driver to check to UI too)
- useful to check integration tests after development to avoid regression issues
run it from ambari-logsearch folder: mvn clean integration-test -Dit.skip=false


Diffs
-

  ambari-logsearch/README.md 23790cd 
  ambari-logsearch/ambari-logsearch-it/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/domain/StoryDataRegistry.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchDockerSteps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/SolrSteps.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStory.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogfeederParsingStory.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-it/src/test/resources/log4j.properties 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-it/src/test/resources/org/apache/ambari/logsearch/story/logfeeder_parsing_story.story
 PRE-CREATION 
  ambari-logsearch/pom.xml 0445c39 

Diff: https://reviews.apache.org/r/50980/diff/


Testing
---

done.


Thanks,

Oliver Szabo