Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-17 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/#review146048
---



Pushed to trunk, commit bc2d2d3784809b9167cdf8ddf1f2badebc7e2409
branch-2.4, commit ef34dae4fe4b15b4c3c1d271dade9123f758e310

- Alejandro Fernandez


On Aug. 16, 2016, 11:19 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51154/
> ---
> 
> (Updated Aug. 16, 2016, 11:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18169
> https://issues.apache.org/jira/browse/AMBARI-18169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should have falcon log4j.xml configurable via ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml
>  0c49209 
> 
> Diff: https://reviews.apache.org/r/51154/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests and passed
> 
> 
> --
> Ran 267 tests in 6.637s
> 
> OK
> --
> Total run:1120
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-17 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/#review146043
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 16, 2016, 11:19 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51154/
> ---
> 
> (Updated Aug. 16, 2016, 11:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18169
> https://issues.apache.org/jira/browse/AMBARI-18169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should have falcon log4j.xml configurable via ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml
>  0c49209 
> 
> Diff: https://reviews.apache.org/r/51154/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests and passed
> 
> 
> --
> Ran 267 tests in 6.637s
> 
> OK
> --
> Total run:1120
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/#review145940
---




ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml 
(line 125)


This will affect HDP 2.1 - 2.5, and existing clusters will add the property 
as soon as they upgrade to Ambari 2.4; just wanted to make sure that is the 
expectation.


- Alejandro Fernandez


On Aug. 16, 2016, 11:19 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51154/
> ---
> 
> (Updated Aug. 16, 2016, 11:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18169
> https://issues.apache.org/jira/browse/AMBARI-18169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should have falcon log4j.xml configurable via ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml
>  0c49209 
> 
> Diff: https://reviews.apache.org/r/51154/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests and passed
> 
> 
> --
> Ran 267 tests in 6.637s
> 
> OK
> --
> Total run:1120
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Venkat Ranganathan 


> On Aug. 16, 2016, 3:09 p.m., Sumit Mohanty wrote:
> > Can you add it to 
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml#L120-L127

Thanks Sumit.  Fixed the metainfo.xml to include the configuration file


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/#review145917
---


On Aug. 16, 2016, 4:19 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51154/
> ---
> 
> (Updated Aug. 16, 2016, 4:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18169
> https://issues.apache.org/jira/browse/AMBARI-18169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should have falcon log4j.xml configurable via ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml
>  0c49209 
> 
> Diff: https://reviews.apache.org/r/51154/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests and passed
> 
> 
> --
> Ran 267 tests in 6.637s
> 
> OK
> --
> Total run:1120
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/
---

(Updated Aug. 16, 2016, 4:19 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Fixed review comments.   Tested in a ambari installed cluster that new Falcon 
service installation allows log4j.xml to be configurable via Ambari


Bugs: AMBARI-18169
https://issues.apache.org/jira/browse/AMBARI-18169


Repository: ambari


Description
---

We should have falcon log4j.xml configurable via ambari


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml 
0c49209 

Diff: https://reviews.apache.org/r/51154/diff/


Testing
---

Ran all unit tests and passed


--
Ran 267 tests in 6.637s

OK
--
Total run:1120
Total errors:0
Total failures:0
OK


Thanks,

Venkat Ranganathan

Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/#review145917
---



Can you add it to 
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml#L120-L127

- Sumit Mohanty


On Aug. 16, 2016, 10 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51154/
> ---
> 
> (Updated Aug. 16, 2016, 10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18169
> https://issues.apache.org/jira/browse/AMBARI-18169
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should have falcon log4j.xml configurable via ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51154/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests and passed
> 
> 
> --
> Ran 267 tests in 6.637s
> 
> OK
> --
> Total run:1120
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari

2016-08-16 Thread Venkat Ranganathan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51154/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-18169
https://issues.apache.org/jira/browse/AMBARI-18169


Repository: ambari


Description
---

We should have falcon log4j.xml configurable via ambari


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51154/diff/


Testing
---

Ran all unit tests and passed


--
Ran 267 tests in 6.637s

OK
--
Total run:1120
Total errors:0
Total failures:0
OK


Thanks,

Venkat Ranganathan