Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-09-08 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/
---

(Updated Сен. 8, 2016, 11:49 д.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-18199
https://issues.apache.org/jira/browse/AMBARI-18199


Repository: ambari


Description
---

On adding additional Collector the webapp address contains wrong hostname.

java.net.BindException: Port in use: ambari-sid-5.com:6188
at 
org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
at 
org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
Caused by: java.net.BindException: Cannot assign requested address

Stop storing collector hostnames in timeline.metrics.service.webapp.address 
property


Diffs (updated)
-

  ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
  ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 822c1a4 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 7352f33 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 c02df71 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 fc95aa7 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 fe00140 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 f3643b1 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
 f0a1d5c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 1c8a86c 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 d5451b2 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 d0ac3a4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 699c51f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
7aeda19 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
 5bd2a9e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 950ade5 
  
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py 
5bfbfc6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json f256216 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
100fefe 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
c2688d0 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
aab07f0 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 081a66a 
  
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
 6b09d33 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
e51e68a 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
42c7403 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
cffec7e 
  ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json cd251d1 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cbb8ee 
  
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java
 42bd3ba 

Diff: https://reviews.apache.org/r/51207/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen



Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-09-06 Thread Dmytro Sen


> On Авг. 19, 2016, 6:18 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 497
> > 
> >
> > We have sharding on sink side, so we should be giving all hosts to the 
> > sink for that to work.

I'll add it in a separate jira, as of now not all the sinks are ready to read 
all hosts, some of them extect to read only one amd hostname from configs.


> On Авг. 19, 2016, 6:18 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py,
> >  line 132
> > 
> >
> > AGain we have host:port for the sinks which should be used by sinks why 
> > do we need to do the single host property here ?

I'll add it in a separate jira, as of now not all the sinks are ready to read 
all hosts, some of them extect to read only one amd hostname from configs.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/#review146200
---


On Авг. 18, 2016, 3:46 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51207/
> ---
> 
> (Updated Авг. 18, 2016, 3:46 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18199
> https://issues.apache.org/jira/browse/AMBARI-18199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On adding additional Collector the webapp address contains wrong hostname.
> 
> java.net.BindException: Port in use: ambari-sid-5.com:6188
> at 
> org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
> at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
> at 
> org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
> at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
> Caused by: java.net.BindException: Cannot assign requested address
> 
> Stop storing collector hostnames in timeline.metrics.service.webapp.address 
> property
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  7352f33 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  fe00140 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f3643b1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  f0a1d5c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  37e2426 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  d5451b2 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d0ac3a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  699c51f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7133c27 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  5bd2a9e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  2c32f7c 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  5bfbfc6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> ceedb67 
>   
> 

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-09-06 Thread Dmytro Sen


> On Авг. 19, 2016, 6:20 п.п., Sid Wagle wrote:
> > The path does everythong expected for the 0.0.0.0:6188 revert and the alert 
> > definition, however not sure about the param.py changes for 1 host these 
> > should not be required since we should be gettign all collectors as 
> > host1:port1,host:2port2 with the changes done for HA.

I'll add it in a separate jira, as of now not all the sinks are ready to read 
all hosts, some of them extect to read only one amd hostname from configs.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/#review146203
---


On Авг. 18, 2016, 3:46 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51207/
> ---
> 
> (Updated Авг. 18, 2016, 3:46 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18199
> https://issues.apache.org/jira/browse/AMBARI-18199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On adding additional Collector the webapp address contains wrong hostname.
> 
> java.net.BindException: Port in use: ambari-sid-5.com:6188
> at 
> org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
> at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
> at 
> org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
> at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
> Caused by: java.net.BindException: Cannot assign requested address
> 
> Stop storing collector hostnames in timeline.metrics.service.webapp.address 
> property
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  7352f33 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  fe00140 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f3643b1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  f0a1d5c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  37e2426 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  d5451b2 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d0ac3a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  699c51f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7133c27 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  5bd2a9e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  2c32f7c 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  5bfbfc6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> ceedb67 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 3692691 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
> 54172f3 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 081a66a 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  7b07d87 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> cf84bb7 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> 6874db5 
>   
> 

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-08-19 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/#review146203
---



The path does everythong expected for the 0.0.0.0:6188 revert and the alert 
definition, however not sure about the param.py changes for 1 host these should 
not be required since we should be gettign all collectors as 
host1:port1,host:2port2 with the changes done for HA.

- Sid Wagle


On Aug. 18, 2016, 3:46 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51207/
> ---
> 
> (Updated Aug. 18, 2016, 3:46 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18199
> https://issues.apache.org/jira/browse/AMBARI-18199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On adding additional Collector the webapp address contains wrong hostname.
> 
> java.net.BindException: Port in use: ambari-sid-5.com:6188
> at 
> org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
> at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
> at 
> org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
> at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
> at 
> org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
> Caused by: java.net.BindException: Cannot assign requested address
> 
> Stop storing collector hostnames in timeline.metrics.service.webapp.address 
> property
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
>  7352f33 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  c02df71 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  fc95aa7 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
>  fe00140 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  f3643b1 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
>  f0a1d5c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  37e2426 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  d5451b2 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d0ac3a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  699c51f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 7133c27 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
>  5bd2a9e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  2c32f7c 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py
>  5bfbfc6 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> ceedb67 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
> 3692691 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
> 54172f3 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 081a66a 
>   
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
>  7b07d87 
>   ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
> cf84bb7 
>   ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
> 6874db5 
>   
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
> 0f5d647 
>   ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json c64ca14 
>   

Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-08-18 Thread Dmytro Sen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51207/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-18199
https://issues.apache.org/jira/browse/AMBARI-18199


Repository: ambari


Description
---

On adding additional Collector the webapp address contains wrong hostname.

java.net.BindException: Port in use: ambari-sid-5.com:6188
at 
org.apache.hadoop.http.HttpServer2.openListeners(HttpServer2.java:919)
at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:856)
at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:374)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.startWebApp(ApplicationHistoryServer.java:180)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.serviceStart(ApplicationHistoryServer.java:92)
at 
org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.launchAppHistoryServer(ApplicationHistoryServer.java:138)
at 
org.apache.hadoop.yarn.server.applicationhistoryservice.ApplicationHistoryServer.main(ApplicationHistoryServer.java:147)
Caused by: java.net.BindException: Cannot assign requested address

Stop storing collector hostnames in timeline.metrics.service.webapp.address 
property


Diffs
-

  ambari-agent/src/test/python/ambari_agent/TestAlerts.py e114daa 
  ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
 7352f33 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 c02df71 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 fc95aa7 
  
ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py
 fe00140 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 f3643b1 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py
 f0a1d5c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 37e2426 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 d5451b2 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 d0ac3a4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 699c51f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
7133c27 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py
 5bd2a9e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 2c32f7c 
  
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_metrics_deviation.py 
5bfbfc6 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 28624fd 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
ceedb67 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_hive_non_hdfs.json 
3692691 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_with_bucket.json 
54172f3 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 081a66a 
  
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json
 7b07d87 
  ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json 
cf84bb7 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json 
6874db5 
  ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 
0f5d647 
  ambari-server/src/test/python/stacks/2.3/configs/ats_1_5.json c64ca14 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 78a0d04 
  
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java
 42bd3ba 

Diff: https://reviews.apache.org/r/51207/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen