Re: Review Request 51530: Provide Notes On Service Config Changes During Ambari Upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51530/#review147997 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 7, 2016, 10:26 до полудня, Dmitro Lisnichenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51530/ > --- > > (Updated Вер. 7, 2016, 10:26 до полудня) > > > Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. > > > Bugs: AMBARI-18278 > https://issues.apache.org/jira/browse/AMBARI-18278 > > > Repository: ambari > > > Description > --- > > For every configuration change made, a meaningful note should be included so > that administrators understand why so many versions are being created. Any of > the following would be fine: > > - Ambari Upgrade updated storm-site > - Ambari Upgrade from 2.2.0 to 2.4.0 changed storm-site > - The following configurations were changed as part of the Ambar Server > Upgrade: storm-site > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 57cce3f > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java > e3b5d15 > > Diff: https://reviews.apache.org/r/51530/diff/ > > > Testing > --- > > checked on live cluster (attached screenshot to jira) > running unit tests > > > Thanks, > > Dmitro Lisnichenko > >
Re: Review Request 51530: Provide Notes On Service Config Changes During Ambari Upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51530/ --- (Updated Sept. 7, 2016, 1:26 p.m.) Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. Changes --- fixed unit tests Bugs: AMBARI-18278 https://issues.apache.org/jira/browse/AMBARI-18278 Repository: ambari Description --- For every configuration change made, a meaningful note should be included so that administrators understand why so many versions are being created. Any of the following would be fine: - Ambari Upgrade updated storm-site - Ambari Upgrade from 2.2.0 to 2.4.0 changed storm-site - The following configurations were changed as part of the Ambar Server Upgrade: storm-site Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 57cce3f ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java e3b5d15 Diff: https://reviews.apache.org/r/51530/diff/ Testing --- checked on live cluster (attached screenshot to jira) running unit tests Thanks, Dmitro Lisnichenko
Review Request 51530: Provide Notes On Service Config Changes During Ambari Upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51530/ --- Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. Bugs: AMBARI-18278 https://issues.apache.org/jira/browse/AMBARI-18278 Repository: ambari Description --- For every configuration change made, a meaningful note should be included so that administrators understand why so many versions are being created. Any of the following would be fine: - Ambari Upgrade updated storm-site - Ambari Upgrade from 2.2.0 to 2.4.0 changed storm-site - The following configurations were changed as part of the Ambar Server Upgrade: storm-site Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java 57cce3f Diff: https://reviews.apache.org/r/51530/diff/ Testing --- checked on live cluster (attached screenshot to jira) running unit tests Thanks, Dmitro Lisnichenko