Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/#review147905 --- Ping. Can this be pushed and close this review? - Nate Cole On Aug. 31, 2016, 4:08 a.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51550/ > --- > > (Updated Aug. 31, 2016, 4:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan > Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. > > > Bugs: AMBARI-18284 > https://issues.apache.org/jira/browse/AMBARI-18284 > > > Repository: ambari > > > Description > --- > > Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when > next time pig view loads the scripts from HDFS those have junk characters. > > > Diffs > - > > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 9dea2a2 > > Diff: https://reviews.apache.org/r/51550/diff/ > > > Testing > --- > > Test Succeeded fine. After aplying the fix the PigView shows the script with > the correct characters. > > > Thanks, > > Jay SenSharma > >
Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
> On Aug. 31, 2016, 1:55 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Can this fix be pushed to trunk? - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/#review147432 --- On Aug. 31, 2016, 8:08 a.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51550/ > --- > > (Updated Aug. 31, 2016, 8:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan > Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. > > > Bugs: AMBARI-18284 > https://issues.apache.org/jira/browse/AMBARI-18284 > > > Repository: ambari > > > Description > --- > > Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when > next time pig view loads the scripts from HDFS those have junk characters. > > > Diffs > - > > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 9dea2a2 > > Diff: https://reviews.apache.org/r/51550/diff/ > > > Testing > --- > > Test Succeeded fine. After aplying the fix the PigView shows the script with > the correct characters. > > > Thanks, > > Jay SenSharma > >
Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/#review147427 --- Ship it! Ship It! - Jonathan Hurley On Aug. 31, 2016, 4:08 a.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51550/ > --- > > (Updated Aug. 31, 2016, 4:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan > Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. > > > Bugs: AMBARI-18284 > https://issues.apache.org/jira/browse/AMBARI-18284 > > > Repository: ambari > > > Description > --- > > Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when > next time pig view loads the scripts from HDFS those have junk characters. > > > Diffs > - > > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 9dea2a2 > > Diff: https://reviews.apache.org/r/51550/diff/ > > > Testing > --- > > Test Succeeded fine. After aplying the fix the PigView shows the script with > the correct characters. > > > Thanks, > > Jay SenSharma > >
Re: Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/#review147423 --- Ship it! Ship It! - Nate Cole On Aug. 31, 2016, 4:08 a.m., Jay SenSharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51550/ > --- > > (Updated Aug. 31, 2016, 4:08 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jonathan > Hurley, Nate Cole, Pallav Kulshreshtha, and Sid Wagle. > > > Bugs: AMBARI-18284 > https://issues.apache.org/jira/browse/AMBARI-18284 > > > Repository: ambari > > > Description > --- > > Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when > next time pig view loads the scripts from HDFS those have junk characters. > > > Diffs > - > > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 9dea2a2 > > Diff: https://reviews.apache.org/r/51550/diff/ > > > Testing > --- > > Test Succeeded fine. After aplying the fix the PigView shows the script with > the correct characters. > > > Thanks, > > Jay SenSharma > >
Review Request 51550: [AMBARI-18284] Ambari PigView stores the pig scripts in HDFS in non UTF-8 format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51550/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18284 https://issues.apache.org/jira/browse/AMBARI-18284 Repository: ambari Description --- Ambari PigView stores the pig scripts in HDFS in non UTF-8 format. So when next time pig view loads the scripts from HDFS those have junk characters. Diffs - contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java 9dea2a2 Diff: https://reviews.apache.org/r/51550/diff/ Testing --- Test Succeeded fine. After aplying the fix the PigView shows the script with the correct characters. Thanks, Jay SenSharma
