Re: Review Request 51600: WebHCat service check should not depend on Pig

[Andrew Onischuk]

> On Sept. 6, 2016, 8:52 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 578
> > 
> >
> > If a service is deleted, so we still pass in the configs? We may 
> > instead want to check how many hosts have PIG client installed.

Good point, but we don't pass client hosts in configurations. Because 1K node 
it would generate too large heartbeats


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/#review147916
---


On Sept. 2, 2016, 2:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51600/
> ---
> 
> (Updated Sept. 2, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18304
> https://issues.apache.org/jira/browse/AMBARI-18304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently WebHCat service check fails on a cluster where Pig is not installed.
> We should eliminate the WebHCat dependency over Pig.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd61631 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  71f930e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 273bd96 
> 
> Diff: https://reviews.apache.org/r/51600/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51600: WebHCat service check should not depend on Pig

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/#review147916
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 578)


If a service is deleted, so we still pass in the configs? We may instead 
want to check how many hosts have PIG client installed.


- Alejandro Fernandez


On Sept. 2, 2016, 2:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51600/
> ---
> 
> (Updated Sept. 2, 2016, 2:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18304
> https://issues.apache.org/jira/browse/AMBARI-18304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently WebHCat service check fails on a cluster where Pig is not installed.
> We should eliminate the WebHCat dependency over Pig.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd61631 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  71f930e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 273bd96 
> 
> Diff: https://reviews.apache.org/r/51600/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51600: WebHCat service check should not depend on Pig

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/#review147661
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Sept. 2, 2016, 5:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51600/
> ---
> 
> (Updated Sept. 2, 2016, 5:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18304
> https://issues.apache.org/jira/browse/AMBARI-18304
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently WebHCat service check fails on a cluster where Pig is not installed.
> We should eliminate the WebHCat dependency over Pig.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd61631 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  5e3e233 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  71f930e 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 273bd96 
> 
> Diff: https://reviews.apache.org/r/51600/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51600: WebHCat service check should not depend on Pig

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/
---

(Updated Sept. 2, 2016, 2:23 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18304
https://issues.apache.org/jira/browse/AMBARI-18304


Repository: ambari


Description
---

Currently WebHCat service check fails on a cluster where Pig is not installed.
We should eliminate the WebHCat dependency over Pig.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 dd61631 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5e3e233 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 71f930e 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
273bd96 

Diff: https://reviews.apache.org/r/51600/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 51600: WebHCat service check should not depend on Pig

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51600/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18304
https://issues.apache.org/jira/browse/AMBARI-18304


Repository: ambari


Description
---

Currently WebHCat service check fails on a cluster where Pig is not installed.
We should eliminate the WebHCat dependency over Pig.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 dd61631 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 5e3e233 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 71f930e 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/files/templetonSmoke.sh
 e26148b 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/params.py
 1159491 
  
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/package/scripts/webhcat_service_check.py
 8d15e47 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
273bd96 

Diff: https://reviews.apache.org/r/51600/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk