---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51616/#review147704
---
Ship it!
Ship It!
- Aravindan Vijayan
On Sept. 2, 2016, 10:06 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51616/
> ---
>
> (Updated Sept. 2, 2016, 10:06 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
>
>
> Bugs: AMBARI-18307
> https://issues.apache.org/jira/browse/AMBARI-18307
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Collector packages the jar file to facilitate sqlline command line
> functionality, the missing piece is the binaries to launch the shell.
>
> This Jira packages the binaries to use sqlline out of the box with AMS
>
> *Note to reviewers:* Only sqlline.py has been edited from the Phoenix 4.4
> distro, log4j and phoenix_utils are ditto.
>
>
> Diffs
> -
>
> ambari-metrics/ambari-metrics-assembly/pom.xml 6efd508
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/log4j.properties
> PRE-CREATION
>
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/phoenix_utils.py
> PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/sqlline/sqlline.py
> PRE-CREATION
> ambari-metrics/ambari-metrics-timelineservice/pom.xml 44d559b
>
> Diff: https://reviews.apache.org/r/51616/diff/
>
>
> Testing
> ---
>
> Verified manually and also by building rpm for script layouts:
>
> /usr/lib/ambari-metrics-collector/bin/sqlline.py
> /usr/lib/ambari-metrics-collector/bin/log4j.properties
> /usr/lib/ambari-metrics-collector/bin/phoenix_utlis.py
>
>
> Thanks,
>
> Sid Wagle
>
>