Re: Review Request 51632: Refactor logsearch portal code

[Oliver Szabo]

> On Sept. 7, 2016, 1:20 p.m., Miklos Gergely wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java,
> >  line 36
> > 
> >
> > The name of the property after the PropertiesFile patch will be applied 
> > is logsearch.auth.external_auth.login_url

https://reviews.apache.org/r/51704/ will contain these fixes


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review148006
---


On Sept. 5, 2016, 4:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51632/
> ---
> 
> (Updated Sept. 5, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - rename/move auditLogRest/manager and serviceLogRest/manager (review board 
> shows it as new added code)
> - using @Inject instead of @Autowired
> - using objects instead of strings for Solr responses (later I want to use 
> spring data solr project to get rid of query generation custom code) ... for 
> that i will fill the Criteria objects with fields as well (now those are only 
> markers)
> - adding converters between requests and search criterias
> - rename and refactor a lot of Vxxx objects, and use them as response objects 
> on endpoints, because of this rest api documentations can show them as they 
> are (not as strings)
> - use javaConfig instead of xml for spring (now security part still in xml, 
> but i will change that later too)
> - move Configuration values into objects, trying to get rid of Property Helper
> 
> Because that is a pretty big change, I created that review, its not done yet 
> (there are still Vxxx objects and also i need to get rid of xml 
> configurations or web.xml as well), also after the documentation was created, 
> there are a lot of unused (or almost duplicated like: 
> componentName/component_name/component) query params there (from the UI), so 
> i will need some manual testing to make sure i can remove them.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml b36c9bb 
>   ambari-logsearch/ambari-logsearch-portal/production/build.js afeea67 
>   ambari-logsearch/ambari-logsearch-portal/production/r.js 6e6ffd0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f58652c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/managed-schema
>  3b4cf19 
>   ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/README.md 
> 3cc4915 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/reset_collections.sh
>  7c742c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/restart_solr.sh
>  bd436bb 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/update_config.sh
>  93e3496 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  15355a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
>  edb4ffa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  5235fab 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  142b29b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/Marker.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertyMapper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  6b74144 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrColumnConfig.java
>  PRE-CREATION 
>   
> 

Re: Review Request 51632: Refactor logsearch portal code

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review148006
---




ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
 (line 33)


You are not using logsearch.auth.external_auth.enable



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
 (line 36)


The name of the property after the PropertiesFile patch will be applied is 
logsearch.auth.external_auth.login_url


- Miklos Gergely


On Sept. 5, 2016, 4:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51632/
> ---
> 
> (Updated Sept. 5, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - rename/move auditLogRest/manager and serviceLogRest/manager (review board 
> shows it as new added code)
> - using @Inject instead of @Autowired
> - using objects instead of strings for Solr responses (later I want to use 
> spring data solr project to get rid of query generation custom code) ... for 
> that i will fill the Criteria objects with fields as well (now those are only 
> markers)
> - adding converters between requests and search criterias
> - rename and refactor a lot of Vxxx objects, and use them as response objects 
> on endpoints, because of this rest api documentations can show them as they 
> are (not as strings)
> - use javaConfig instead of xml for spring (now security part still in xml, 
> but i will change that later too)
> - move Configuration values into objects, trying to get rid of Property Helper
> 
> Because that is a pretty big change, I created that review, its not done yet 
> (there are still Vxxx objects and also i need to get rid of xml 
> configurations or web.xml as well), also after the documentation was created, 
> there are a lot of unused (or almost duplicated like: 
> componentName/component_name/component) query params there (from the UI), so 
> i will need some manual testing to make sure i can remove them.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml b36c9bb 
>   ambari-logsearch/ambari-logsearch-portal/production/build.js afeea67 
>   ambari-logsearch/ambari-logsearch-portal/production/r.js 6e6ffd0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f58652c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/managed-schema
>  3b4cf19 
>   ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/README.md 
> 3cc4915 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/reset_collections.sh
>  7c742c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/restart_solr.sh
>  bd436bb 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/update_config.sh
>  93e3496 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  15355a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
>  edb4ffa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  5235fab 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  142b29b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/Marker.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertyMapper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  6b74144 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogConfig.java
>  PRE-CREATION 
>   
> 

Re: Review Request 51632: Refactor logsearch portal code

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review147833
---


Ship it!




Ship It!

- Miklos Gergely


On Sept. 5, 2016, 4:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51632/
> ---
> 
> (Updated Sept. 5, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - rename/move auditLogRest/manager and serviceLogRest/manager (review board 
> shows it as new added code)
> - using @Inject instead of @Autowired
> - using objects instead of strings for Solr responses (later I want to use 
> spring data solr project to get rid of query generation custom code) ... for 
> that i will fill the Criteria objects with fields as well (now those are only 
> markers)
> - adding converters between requests and search criterias
> - rename and refactor a lot of Vxxx objects, and use them as response objects 
> on endpoints, because of this rest api documentations can show them as they 
> are (not as strings)
> - use javaConfig instead of xml for spring (now security part still in xml, 
> but i will change that later too)
> - move Configuration values into objects, trying to get rid of Property Helper
> 
> Because that is a pretty big change, I created that review, its not done yet 
> (there are still Vxxx objects and also i need to get rid of xml 
> configurations or web.xml as well), also after the documentation was created, 
> there are a lot of unused (or almost duplicated like: 
> componentName/component_name/component) query params there (from the UI), so 
> i will need some manual testing to make sure i can remove them.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml b36c9bb 
>   ambari-logsearch/ambari-logsearch-portal/production/build.js afeea67 
>   ambari-logsearch/ambari-logsearch-portal/production/r.js 6e6ffd0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f58652c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/managed-schema
>  3b4cf19 
>   ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/README.md 
> 3cc4915 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/reset_collections.sh
>  7c742c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/restart_solr.sh
>  bd436bb 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/update_config.sh
>  93e3496 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  15355a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
>  edb4ffa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  5235fab 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  142b29b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/Marker.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertyMapper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  6b74144 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrColumnConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  PRE-CREATION 
>   
> 

Re: Review Request 51632: Refactor logsearch portal code

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51632/#review147797
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 5, 2016, 6:46 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51632/
> ---
> 
> (Updated Sept. 5, 2016, 6:46 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, 
> Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - rename/move auditLogRest/manager and serviceLogRest/manager (review board 
> shows it as new added code)
> - using @Inject instead of @Autowired
> - using objects instead of strings for Solr responses (later I want to use 
> spring data solr project to get rid of query generation custom code) ... for 
> that i will fill the Criteria objects with fields as well (now those are only 
> markers)
> - adding converters between requests and search criterias
> - rename and refactor a lot of Vxxx objects, and use them as response objects 
> on endpoints, because of this rest api documentations can show them as they 
> are (not as strings)
> - use javaConfig instead of xml for spring (now security part still in xml, 
> but i will change that later too)
> - move Configuration values into objects, trying to get rid of Property Helper
> 
> Because that is a pretty big change, I created that review, its not done yet 
> (there are still Vxxx objects and also i need to get rid of xml 
> configurations or web.xml as well), also after the documentation was created, 
> there are a lot of unused (or almost duplicated like: 
> componentName/component_name/component) query params there (from the UI), so 
> i will need some manual testing to make sure i can remove them.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml b36c9bb 
>   ambari-logsearch/ambari-logsearch-portal/production/build.js afeea67 
>   ambari-logsearch/ambari-logsearch-portal/production/r.js 6e6ffd0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f58652c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hadoop_logs/conf/managed-schema
>  3b4cf19 
>   ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/README.md 
> 3cc4915 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/reset_collections.sh
>  7c742c0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/restart_solr.sh
>  bd436bb 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/dev/solrcloud/update_config.sh
>  93e3496 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  15355a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ConfigHelper.java
>  edb4ffa 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  5235fab 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  142b29b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/Marker.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertyMapper.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/SearchCriteria.java
>  6b74144 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/AuthConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrColumnConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionConfig.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  PRE-CREATION 
>   
>