Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/
---

(Updated Sept. 7, 2016, 12:48 p.m.)


Review request for Ambari, Robert Nettleton and Sumit Mohanty.


Changes
---

Added branch-2.5 to the list of branches.


Bugs: AMBARI-18328
https://issues.apache.org/jira/browse/AMBARI-18328


Repository: ambari


Description
---

AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
log file


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 de998cea801dba4b554255b209d20fb61bca36cc 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
 2f4f890ddbc922fc732334e450d45d30222b2216 

Diff: https://reviews.apache.org/r/51685/diff/


Testing
---

** Manual Testing **
Deployed a VM with the latest trunk build and patched ambari-server JAR with 
the one from the local build. Ran a blueprint deployed and verified that the 
*settings* section of the blueprint was logged in 
/var/log/ambari-server/ambari-server.log.

** mvn test -Dtest=Blueprint*Test -DskipPythonTests **

Results :

Tests run: 245, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 39.290s
[INFO] Finished at: Wed Sep 07 12:26:24 PDT 2016
[INFO] Final Memory: 54M/861M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Robert Nettleton]

> On Sept. 7, 2016, 1:58 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java,
> >  line 499
> > 
> >
> > Why is this being logged? 
> > 
> > It seems to me that you should be able to just GET the Blueprint back 
> > from the Ambari REST API, so logging this here seems redundant, especially 
> > considering that we generally don't log pieces of the Blueprint during the 
> > Blueprint POST. 
> > 
> > Is this section returned properly via the Blueprint GET call?
> 
> Nahappan Somasundaram wrote:
> Looking at the ambari logs, we want to figure out the auto start 
> configuration, without having to query the cluster. I agree that we don't log 
> pieces of the blueprint. The *settings* section is typically very small so 
> logging it will not take up much space in the logs. 
> 
> https://issues.apache.org/jira/browse/AMBARI-18332 tracks the API fix.

Ok, thanks for clarifying this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/#review148010
---


On Sept. 7, 2016, 7:29 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51685/
> ---
> 
> (Updated Sept. 7, 2016, 7:29 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18328
> https://issues.apache.org/jira/browse/AMBARI-18328
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
> log file
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  de998cea801dba4b554255b209d20fb61bca36cc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
>  2f4f890ddbc922fc732334e450d45d30222b2216 
> 
> Diff: https://reviews.apache.org/r/51685/diff/
> 
> 
> Testing
> ---
> 
> ** Manual Testing **
> Deployed a VM with the latest trunk build and patched ambari-server JAR with 
> the one from the local build. Ran a blueprint deployed and verified that the 
> *settings* section of the blueprint was logged in 
> /var/log/ambari-server/ambari-server.log.
> 
> ** mvn test -Dtest=Blueprint*Test -DskipPythonTests **
> 
> Results :
> 
> Tests run: 245, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 39.290s
> [INFO] Finished at: Wed Sep 07 12:26:24 PDT 2016
> [INFO] Final Memory: 54M/861M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/
---

(Updated Sept. 7, 2016, 12:29 p.m.)


Review request for Ambari, Robert Nettleton and Sumit Mohanty.


Changes
---

Fixed broken UTs for BlueprintResourceProviderTests.


Bugs: AMBARI-18328
https://issues.apache.org/jira/browse/AMBARI-18328


Repository: ambari


Description
---

AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
log file


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 de998cea801dba4b554255b209d20fb61bca36cc 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
 2f4f890ddbc922fc732334e450d45d30222b2216 

Diff: https://reviews.apache.org/r/51685/diff/


Testing (updated)
---

** Manual Testing **
Deployed a VM with the latest trunk build and patched ambari-server JAR with 
the one from the local build. Ran a blueprint deployed and verified that the 
*settings* section of the blueprint was logged in 
/var/log/ambari-server/ambari-server.log.

** mvn test -Dtest=Blueprint*Test -DskipPythonTests **

Results :

Tests run: 245, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 39.290s
[INFO] Finished at: Wed Sep 07 12:26:24 PDT 2016
[INFO] Final Memory: 54M/861M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/#review148010
---


Fix it, then Ship it!




The change looks fine to me, just need a clarification as to why this is being 
logged in addition to being available via the REST API. 

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 (line 499)


Why is this being logged? 

It seems to me that you should be able to just GET the Blueprint back from 
the Ambari REST API, so logging this here seems redundant, especially 
considering that we generally don't log pieces of the Blueprint during the 
Blueprint POST. 

Is this section returned properly via the Blueprint GET call?


- Robert Nettleton


On Sept. 7, 2016, 2:14 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51685/
> ---
> 
> (Updated Sept. 7, 2016, 2:14 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-18328
> https://issues.apache.org/jira/browse/AMBARI-18328
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
> log file
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  de998cea801dba4b554255b209d20fb61bca36cc 
> 
> Diff: https://reviews.apache.org/r/51685/diff/
> 
> 
> Testing
> ---
> 
> ** Manual Testing **
> Deployed a VM with the latest trunk build and patched ambari-server JAR with 
> the one from the local build. Ran a blueprint deployed and verified that the 
> *settings* section of the blueprint was logged in 
> /var/log/ambari-server/ambari-server.log.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/#review147964
---


Ship it!




Ship It!

- Sumit Mohanty


On Sept. 7, 2016, 2:14 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51685/
> ---
> 
> (Updated Sept. 7, 2016, 2:14 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-18328
> https://issues.apache.org/jira/browse/AMBARI-18328
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
> log file
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  de998cea801dba4b554255b209d20fb61bca36cc 
> 
> Diff: https://reviews.apache.org/r/51685/diff/
> 
> 
> Testing
> ---
> 
> ** Manual Testing **
> Deployed a VM with the latest trunk build and patched ambari-server JAR with 
> the one from the local build. Ran a blueprint deployed and verified that the 
> *settings* section of the blueprint was logged in 
> /var/log/ambari-server/ambari-server.log.
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Review Request 51685: AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server log file

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51685/
---

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-18328
https://issues.apache.org/jira/browse/AMBARI-18328


Repository: ambari


Description
---

AMBARI-18328: Blueprints: Log "setting" section of blueprint in ambari server 
log file


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 de998cea801dba4b554255b209d20fb61bca36cc 

Diff: https://reviews.apache.org/r/51685/diff/


Testing
---

** Manual Testing **
Deployed a VM with the latest trunk build and patched ambari-server JAR with 
the one from the local build. Ran a blueprint deployed and verified that the 
*settings* section of the blueprint was logged in 
/var/log/ambari-server/ambari-server.log.


Thanks,

Nahappan Somasundaram