Re: Review Request 51698: Added database metrics source

2016-09-08 Thread Li-Wei Tseng

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51698/
---

(Updated Sept. 8, 2016, 9:05 p.m.)


Review request for Ambari and Aravindan Vijayan.


Bugs: AMBARI-17589
https://issues.apache.org/jira/browse/AMBARI-17589


Repository: ambari


Description
---

Added Database metrics generated by Eclipselink Performance Profiler


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties 5f01e39 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 d20b1d7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 bd34c25 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 809176be 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 23845c9 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 cf10408 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 58e2045 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 4618618 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 705971f 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 a04ca43 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 1645ebf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java
 6717e01 
  ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 
  
ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51698/diff/


Testing
---

Unit test for emit metrics to AMS


Thanks,

Li-Wei Tseng



Re: Review Request 51698: Added database metrics source

2016-09-08 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51698/#review148252
---




ambari-server/conf/unix/metrics.properties (line 28)


Can you uppercase DB instead of Db for consistency.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 888)


Why? If MetricsServiceImpl is injected it can get this from guice instead 
of setter method.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricsSource.java
 (line 53)


Sources should not get a passed down serverConfig if what it realy needs is 
just hostname property.


- Sid Wagle


On Sept. 8, 2016, 8:25 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51698/
> ---
> 
> (Updated Sept. 8, 2016, 8:25 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-17589
> https://issues.apache.org/jira/browse/AMBARI-17589
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Database metrics generated by Eclipselink Performance Profiler
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties 5f01e39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  d20b1d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  bd34c25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  809176be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  23845c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  cf10408 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  58e2045 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  4618618 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  705971f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  a04ca43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  1645ebf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java
>  6717e01 
>   ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51698/diff/
> 
> 
> Testing
> ---
> 
> Unit test for emit metrics to AMS
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>



Re: Review Request 51698: Added database metrics source

2016-09-08 Thread Li-Wei Tseng

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51698/
---

(Updated Sept. 8, 2016, 8:25 p.m.)


Review request for Ambari and Aravindan Vijayan.


Bugs: AMBARI-17589
https://issues.apache.org/jira/browse/AMBARI-17589


Repository: ambari


Description
---

Added Database metrics generated by Eclipselink Performance Profiler


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties 5f01e39 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 d20b1d7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 bd34c25 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 809176be 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 23845c9 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 cf10408 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 58e2045 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 4618618 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 705971f 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 a04ca43 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 1645ebf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java
 6717e01 
  ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 
  
ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51698/diff/


Testing
---

Unit test for emit metrics to AMS


Thanks,

Li-Wei Tseng



Re: Review Request 51698: Added database metrics source

2016-09-07 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51698/#review148070
---




ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 (line 377)


Unncessary comments.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 (line 50)


We should try configuration for supplied hostname, if not found then switch 
to InetAddress, which can be unreliable or not what user wants.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
 (line 66)


Please define and enum or EnumSet and put comments.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
 (line 137)


This is not a threadsafe check. Necessary to declare isInint as volatile. 
Best is to do the init outside this method call.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
 (line 34)


If this instance is created by guice, why the private constructor?



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
 (line 35)


Can you rename to DBMetricsSource, since interface is named MetricsSource 
(plural)



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
 (line 43)


Not the optimium impl of Singleton patter if you have have to use it, 
static reference instantiation is recommeneded.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 (line 51)


Again improper use of Singleton. Why is guice not used ?


- Sid Wagle


On Sept. 7, 2016, 5:59 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51698/
> ---
> 
> (Updated Sept. 7, 2016, 5:59 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-17589
> https://issues.apache.org/jira/browse/AMBARI-17589
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Database metrics generated by Eclipselink Performance Profiler
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties 5f01e39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  d20b1d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  bd34c25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  809176be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  23845c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  cf10408 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  58e2045 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  4618618 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  705971f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  a04ca43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  1645ebf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java
>  6717e01 
>   ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51698/diff/
> 
> 
> Testing
> ---
> 
> Unit test for emit metrics to AMS
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>



Re: Review Request 51698: Added database metrics source

2016-09-07 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51698/#review148050
---




ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
 (line 66)


What are these values?



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
 (line 81)


Should this be case insensitive match?


- Alejandro Fernandez


On Sept. 7, 2016, 5:59 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51698/
> ---
> 
> (Updated Sept. 7, 2016, 5:59 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-17589
> https://issues.apache.org/jira/browse/AMBARI-17589
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Database metrics generated by Eclipselink Performance Profiler
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties 5f01e39 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  d20b1d7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  bd34c25 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  809176be 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  23845c9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  cf10408 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  58e2045 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  4618618 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  705971f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  a04ca43 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  1645ebf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java
>  6717e01 
>   ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 
>   
> ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51698/diff/
> 
> 
> Testing
> ---
> 
> Unit test for emit metrics to AMS
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>



Review Request 51698: Added database metrics source

2016-09-07 Thread Li-Wei Tseng

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51698/
---

Review request for Ambari and Aravindan Vijayan.


Bugs: AMBARI-17589
https://issues.apache.org/jira/browse/AMBARI-17589


Repository: ambari


Description
---

Added Database metrics generated by Eclipselink Performance Profiler


Diffs
-

  ambari-server/conf/unix/metrics.properties 5f01e39 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 d20b1d7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 bd34c25 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 809176be 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 23845c9 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 cf10408 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 58e2045 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 4618618 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 705971f 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DBSessionEventListener.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DbMetricSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 a04ca43 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 1645ebf 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/EclipseLinkSessionCustomizer.java
 6717e01 
  ambari-server/src/main/resources/META-INF/persistence.xml 2bc3282 
  
ambari-server/src/test/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImplTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51698/diff/


Testing
---

Unit test for emit metrics to AMS


Thanks,

Li-Wei Tseng