Re: Review Request 51813: Modify the AMS stack scripts to support distributed collector

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51813/#review149268
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 16, 2016, 1:06 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51813/
> ---
> 
> (Updated Sept. 16, 2016, 1:06 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-17457
> https://issues.apache.org/jira/browse/AMBARI-17457
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix service check to andle AMS HA
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 
> 7b4e8f5 
>   ambari-common/src/main/python/ambari_commons/parallel_processing.py 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
>  e8c12ed 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  22024bb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  ddd3e42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2
>  678d769 
> 
> Diff: https://reviews.apache.org/r/51813/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 51813: Modify the AMS stack scripts to support distributed collector

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51813/
---

(Updated Сен. 16, 2016, 1:06 п.п.)


Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17457
https://issues.apache.org/jira/browse/AMBARI-17457


Repository: ambari


Description
---

Fix service check to andle AMS HA


Diffs (updated)
-

  ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py 7b4e8f5 
  ambari-common/src/main/python/ambari_commons/parallel_processing.py 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py
 e8c12ed 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 22024bb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 ddd3e42 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2
 678d769 

Diff: https://reviews.apache.org/r/51813/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 51813: Modify the AMS stack scripts to support distributed collector

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51813/#review148533
---




ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 (line 42)


Aggree that 30 is too high but 5 is too low, how about 10 ?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 (line 45)


I think this should be 10 secs linke server sice default. Rest of the 
settings make sense.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 (line 76)


Can we do this in parallel?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 (line 153)


We should log the same output as the exception since plain old message 
would not be meaningful in the log.


- Sid Wagle


On Sept. 12, 2016, 3:59 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51813/
> ---
> 
> (Updated Sept. 12, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-17457
> https://issues.apache.org/jira/browse/AMBARI-17457
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix service check to andle AMS HA
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
>  ddd3e42 
> 
> Diff: https://reviews.apache.org/r/51813/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 51813: Modify the AMS stack scripts to support distributed collector

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51813/
---

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-17457
https://issues.apache.org/jira/browse/AMBARI-17457


Repository: ambari


Description
---

Fix service check to andle AMS HA


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 ddd3e42 

Diff: https://reviews.apache.org/r/51813/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen