Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/#review148963 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 14, 2016, 8:40 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51897/ > --- > > (Updated Sept. 14, 2016, 8:40 p.m.) > > > Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and > Yusaku Sako. > > > Bugs: AMBARI-18389 > https://issues.apache.org/jira/browse/AMBARI-18389 > > > Repository: ambari > > > Description > --- > > "placeholder" only make sense when config is editable. > > > Diffs > - > > ambari-web/app/models/configs/objects/service_config_property.js 0c7673d > ambari-web/test/models/configs/objects/service_config_property_test.js > a6772d3 > > Diff: https://reviews.apache.org/r/51897/diff/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/ --- (Updated Sept. 14, 2016, 8:40 p.m.) Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Changes --- Add all related fields to dependency. Bugs: AMBARI-18389 https://issues.apache.org/jira/browse/AMBARI-18389 Repository: ambari Description --- "placeholder" only make sense when config is editable. Diffs (updated) - ambari-web/app/models/configs/objects/service_config_property.js 0c7673d ambari-web/test/models/configs/objects/service_config_property_test.js a6772d3 Diff: https://reviews.apache.org/r/51897/diff/ Testing --- Manually tested on live cluster, all unit tests passed. Thanks, Richard Zang
Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/#review148956 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 14, 2016, 7:27 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51897/ > --- > > (Updated Sept. 14, 2016, 7:27 p.m.) > > > Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and > Yusaku Sako. > > > Bugs: AMBARI-18389 > https://issues.apache.org/jira/browse/AMBARI-18389 > > > Repository: ambari > > > Description > --- > > "placeholder" only make sense when config is editable. > > > Diffs > - > > ambari-web/app/models/configs/objects/service_config_property.js 0c7673d > ambari-web/test/models/configs/objects/service_config_property_test.js > a6772d3 > > Diff: https://reviews.apache.org/r/51897/diff/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > > > Thanks, > > Richard Zang > >
Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/ --- Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. Bugs: AMBARI-18389 https://issues.apache.org/jira/browse/AMBARI-18389 Repository: ambari Description --- "placeholder" only make sense when config is editable. Diffs - ambari-web/app/models/configs/objects/service_config_property.js 0c7673d ambari-web/test/models/configs/objects/service_config_property_test.js a6772d3 Diff: https://reviews.apache.org/r/51897/diff/ Testing --- Manually tested on live cluster, all unit tests passed. Thanks, Richard Zang
