Re: Review Request 52178: Ambari create widget does not show what the error is

2016-09-22 Thread Zhe (Joe) Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52178/#review150111
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Sept. 22, 2016, 11:55 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52178/
> ---
> 
> (Updated Sept. 22, 2016, 11:55 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18449
> https://issues.apache.org/jira/browse/AMBARI-18449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Tried to create a custom widget but the next button was disabled. However the 
> UI did not show what the error was
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 
> 4e3ab91 
>   ambari-web/app/templates/main/service/widgets/create/expression.hbs 826cb43 
>   ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs 
> 17e4790 
>   ambari-web/app/templates/main/service/widgets/create/step2_number.hbs 
> 27fd7e4 
>   ambari-web/app/templates/main/service/widgets/create/step2_template.hbs 
> 6a8a469 
>   ambari-web/app/views/main/service/widgets/create/expression_view.js 32c664f 
> 
> Diff: https://reviews.apache.org/r/52178/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> 
> Ambari-web unit tests pass.
> 30368 tests complete (27 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>



Review Request 52178: Ambari create widget does not show what the error is

2016-09-22 Thread Vivek Ratnavel Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52178/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.


Bugs: AMBARI-18449
https://issues.apache.org/jira/browse/AMBARI-18449


Repository: ambari


Description
---

Tried to create a custom widget but the next button was disabled. However the 
UI did not show what the error was


Diffs
-

  ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 
4e3ab91 
  ambari-web/app/templates/main/service/widgets/create/expression.hbs 826cb43 
  ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs 17e4790 
  ambari-web/app/templates/main/service/widgets/create/step2_number.hbs 27fd7e4 
  ambari-web/app/templates/main/service/widgets/create/step2_template.hbs 
6a8a469 
  ambari-web/app/views/main/service/widgets/create/expression_view.js 32c664f 

Diff: https://reviews.apache.org/r/52178/diff/


Testing
---

Verified manually.

Ambari-web unit tests pass.
30368 tests complete (27 seconds)
151 tests pending


Thanks,

Vivek Ratnavel Subramanian