Re: Review Request 52340: Refactor solr layer in logsearch

2016-10-05 Thread Oliver Szabo
> On Oct. 4, 2016, 9:36 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java, > > line 42 > > > > > > A cast like

Re: Review Request 52340: Refactor solr layer in logsearch

2016-10-04 Thread Oliver Szabo
> On Oct. 4, 2016, 9:36 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java, > > line 42 > > > > > > A cast like

Re: Review Request 52340: Refactor solr layer in logsearch

2016-10-04 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/#review151225 --- Fix it, then Ship it! The patch looks fine to me.

Re: Review Request 52340: Refactor solr layer in logsearch

2016-10-03 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/ --- (Updated Oct. 3, 2016, 9:58 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 52340: Refactor solr layer in logsearch

2016-10-03 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/#review151146 --- Fix it, then Ship it! Fix it, then ship it

Re: Review Request 52340: Refactor solr layer in logsearch

2016-09-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/ --- (Updated Sept. 30, 2016, 7:45 p.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 52340: Refactor solr layer in logsearch

2016-09-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/ --- (Updated Sept. 29, 2016, 4:24 p.m.) Review request for Ambari, Miklos Gergely,

Review Request 52340: Refactor solr layer in logsearch

2016-09-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and

Review Request 52340: Refactor solr layer in logsearch

2016-09-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52340/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and