Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

2016-11-01 Thread Ashwin Rajeev

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154505
---


Ship it!




Ship It!

- Ashwin Rajeev


On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52823/
> ---
> 
> (Updated Oct. 13, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18584
> https://issues.apache.org/jira/browse/AMBARI-18584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier GsonJsonProvider was trying to convert uploaded InputStream because 
> the content type that was coming was application/json for files with 
> extension .json
> Now the GsonJsonProvider will ignore conversion of object of InputStream.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
> 
> Diff: https://reviews.apache.org/r/52823/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

2016-11-01 Thread Pallav Kulshreshtha

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154504
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52823/
> ---
> 
> (Updated Oct. 13, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18584
> https://issues.apache.org/jira/browse/AMBARI-18584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier GsonJsonProvider was trying to convert uploaded InputStream because 
> the content type that was coming was application/json for files with 
> extension .json
> Now the GsonJsonProvider will ignore conversion of object of InputStream.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
> 
> Diff: https://reviews.apache.org/r/52823/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

2016-11-01 Thread Gaurav Nagar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154495
---


Ship it!




Ship It!

- Gaurav Nagar


On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52823/
> ---
> 
> (Updated Oct. 13, 2016, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-18584
> https://issues.apache.org/jira/browse/AMBARI-18584
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier GsonJsonProvider was trying to convert uploaded InputStream because 
> the content type that was coming was application/json for files with 
> extension .json
> Now the GsonJsonProvider will ignore conversion of object of InputStream.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java
>  8ba9ff7 
> 
> Diff: https://reviews.apache.org/r/52823/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing Done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>



Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

2016-10-13 Thread Nitiraj Rathore

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-18584
https://issues.apache.org/jira/browse/AMBARI-18584


Repository: ambari


Description
---

Earlier GsonJsonProvider was trying to convert uploaded InputStream because the 
content type that was coming was application/json for files with extension .json
Now the GsonJsonProvider will ignore conversion of object of InputStream.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java 
8ba9ff7 

Diff: https://reviews.apache.org/r/52823/diff/


Testing
---

Manual Testing Done.


Thanks,

Nitiraj Rathore