Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Balázs Bence Sári 


> On Oct. 18, 2016, 4:41 p.m., Jayush Luniya wrote:
> > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml,
> >  line 35
> > 
> >
> > Rename to microsoft_r_node_client.py?

I didn't change the convention (the script was named after the service). Do you 
want this to be changed in a new patch?


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/#review153111
---


On Oct. 14, 2016, 10:07 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52860/
> ---
> 
> (Updated Oct. 14, 2016, 10:07 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18597
> https://issues.apache.org/jira/browse/AMBARI-18597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename service to "Microsoft R Server" and component to "Microsoft R Node 
> Client" in the Microsoft R management pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  397c22d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/kerberos.json
>  86fab2d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
>  6c5f062 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py
>  f6eb33e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/service_check.py
>  5368e94 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/role_command_order.json
>  6edbc2c 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/service_advisor.py
>  d48afec 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R_SERVER/8.0.5/role_command_order.json
>  PRE-CREATION 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml
>  9470d22 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/repos/repoinfo.xml
>   
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> eb7076c 
> 
> Diff: https://reviews.apache.org/r/52860/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installation and kerberization.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/#review153111
---




contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
 (line 35)


Rename to microsoft_r_node_client.py?


- Jayush Luniya


On Oct. 14, 2016, 10:07 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52860/
> ---
> 
> (Updated Oct. 14, 2016, 10:07 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18597
> https://issues.apache.org/jira/browse/AMBARI-18597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename service to "Microsoft R Server" and component to "Microsoft R Node 
> Client" in the Microsoft R management pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  397c22d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/kerberos.json
>  86fab2d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
>  6c5f062 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py
>  f6eb33e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/service_check.py
>  5368e94 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/role_command_order.json
>  6edbc2c 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/service_advisor.py
>  d48afec 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R_SERVER/8.0.5/role_command_order.json
>  PRE-CREATION 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml
>  9470d22 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/repos/repoinfo.xml
>   
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> eb7076c 
> 
> Diff: https://reviews.apache.org/r/52860/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installation and kerberization.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-18 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/#review153109
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 14, 2016, 10:07 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52860/
> ---
> 
> (Updated Oct. 14, 2016, 10:07 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18597
> https://issues.apache.org/jira/browse/AMBARI-18597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename service to "Microsoft R Server" and component to "Microsoft R Node 
> Client" in the Microsoft R management pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  397c22d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/kerberos.json
>  86fab2d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
>  6c5f062 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py
>  f6eb33e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/service_check.py
>  5368e94 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/role_command_order.json
>  6edbc2c 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/service_advisor.py
>  d48afec 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R_SERVER/8.0.5/role_command_order.json
>  PRE-CREATION 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml
>  9470d22 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/repos/repoinfo.xml
>   
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> eb7076c 
> 
> Diff: https://reviews.apache.org/r/52860/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installation and kerberization.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-15 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/#review152786
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 14, 2016, 12:07 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52860/
> ---
> 
> (Updated Oct. 14, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18597
> https://issues.apache.org/jira/browse/AMBARI-18597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename service to "Microsoft R Server" and component to "Microsoft R Node 
> Client" in the Microsoft R management pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  397c22d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/kerberos.json
>  86fab2d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
>  6c5f062 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py
>  f6eb33e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/service_check.py
>  5368e94 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/role_command_order.json
>  6edbc2c 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/service_advisor.py
>  d48afec 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R_SERVER/8.0.5/role_command_order.json
>  PRE-CREATION 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml
>  9470d22 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/repos/repoinfo.xml
>   
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> eb7076c 
> 
> Diff: https://reviews.apache.org/r/52860/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installation and kerberization.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-15 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/#review152780
---


Ship it!




Also tested with blueprints.

- Attila Doroszlai


On Oct. 14, 2016, 12:07 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52860/
> ---
> 
> (Updated Oct. 14, 2016, 12:07 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18597
> https://issues.apache.org/jira/browse/AMBARI-18597
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Rename service to "Microsoft R Server" and component to "Microsoft R Node 
> Client" in the Microsoft R management pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  397c22d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/kerberos.json
>  86fab2d 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
>  6c5f062 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/files/microsoft_r_serviceCheck.r
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py
>  f6eb33e 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_linux.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_windows.py
>   
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/service_check.py
>  5368e94 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/role_command_order.json
>  6edbc2c 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/service_advisor.py
>  d48afec 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R_SERVER/8.0.5/role_command_order.json
>  PRE-CREATION 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml
>  9470d22 
>   
> contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/repos/repoinfo.xml
>   
>   contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
> eb7076c 
> 
> Diff: https://reviews.apache.org/r/52860/diff/
> 
> 
> Testing
> ---
> 
> Manually tested installation and kerberization.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 52860: Rename service to "Microsoft R Server" and component to "Microsoft R Node Client"

2016-10-14 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52860/
---

Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, and 
Sebastian Toader.


Bugs: AMBARI-18597
https://issues.apache.org/jira/browse/AMBARI-18597


Repository: ambari


Description
---

Rename service to "Microsoft R Server" and component to "Microsoft R Node 
Client" in the Microsoft R management pack.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 397c22d 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/kerberos.json
 86fab2d 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/metainfo.xml
 6c5f062 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/files/microsoft_r_serviceCheck.r
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/microsoft_r.py
 f6eb33e 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_linux.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/params_windows.py
  
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/package/scripts/service_check.py
 5368e94 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/role_command_order.json
 6edbc2c 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.5/service_advisor.py
 d48afec 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R_SERVER/8.0.5/role_command_order.json
 PRE-CREATION 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/metainfo.xml
 9470d22 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.5/repos/repoinfo.xml
  
  contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
eb7076c 

Diff: https://reviews.apache.org/r/52860/diff/


Testing
---

Manually tested installation and kerberization.


Thanks,

Balázs Bence Sári