Re: Review Request 52892: AMBARI-18601 : Analyze and Optimize Ambari Server Unit Tests - - Group 4

2016-10-14 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52892/#review152702
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 14, 2016, 5:36 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52892/
> ---
> 
> (Updated Oct. 14, 2016, 5:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18601
> https://issues.apache.org/jira/browse/AMBARI-18601
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> | Test  Old Time  New Time (s)
> |UpgradeCatalog220Test  60.285 11
> |ConfigHelperTest 45.862 10
> |ServiceComponentTest 31.207 10
> |AMSPropertyProviderTest  38.724  4
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  05fa880 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  37a48f0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  b043da1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java
>  7c1605d 
> 
> Diff: https://reviews.apache.org/r/52892/diff/
> 
> 
> Testing
> ---
> 
> Relevant unit tests passed.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>



Review Request 52892: AMBARI-18601 : Analyze and Optimize Ambari Server Unit Tests - - Group 4

2016-10-14 Thread Aravindan Vijayan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52892/
---

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18601
https://issues.apache.org/jira/browse/AMBARI-18601


Repository: ambari


Description
---

| Test  Old Time  New Time (s)
|UpgradeCatalog220Test60.285 11
|ConfigHelperTest 45.862 10
|ServiceComponentTest 31.207 10
|AMSPropertyProviderTest  38.724  4


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
 05fa880 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 37a48f0 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
 b043da1 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java
 7c1605d 

Diff: https://reviews.apache.org/r/52892/diff/


Testing
---

Relevant unit tests passed.


Thanks,

Aravindan Vijayan