Re: Review Request 54249: Remove unnecessary Log Feeder Date Mapper tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54249/ --- (Updated Dec. 2, 2016, 2:16 p.m.) Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and Sebastian Toader. Changes --- remove branch-2.4 as the test wasn't present there Bugs: AMBARI-19045 https://issues.apache.org/jira/browse/AMBARI-19045 Repository: ambari Description --- Some unit tests for Date Mapper in the Log Feeder (testMapperDate_patternWithoutYear_previousYearLog, testMapperDate_patternWithoutYear_currentYearLog) make no sense, but fail in December. Remove these tests. Options Diffs - ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperDateTest.java 667c9ff Diff: https://reviews.apache.org/r/54249/diff/ Testing --- - Thanks, Miklos Gergely
Re: Review Request 54249: Remove unnecessary Log Feeder Date Mapper tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54249/#review157590 --- Ship it! Ship It! - Robert Nettleton On Dec. 1, 2016, 10:16 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54249/ > --- > > (Updated Dec. 1, 2016, 10:16 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-19045 > https://issues.apache.org/jira/browse/AMBARI-19045 > > > Repository: ambari > > > Description > --- > > Some unit tests for Date Mapper in the Log Feeder > (testMapperDate_patternWithoutYear_previousYearLog, > testMapperDate_patternWithoutYear_currentYearLog) make no sense, but fail in > December. Remove these tests. > Options > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperDateTest.java > 667c9ff > > Diff: https://reviews.apache.org/r/54249/diff/ > > > Testing > --- > > - > > > Thanks, > > Miklos Gergely > >
Re: Review Request 54249: Remove unnecessary Log Feeder Date Mapper tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54249/#review157566 --- Ship it! Ship It! - Oliver Szabo On Dec. 1, 2016, 10:16 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54249/ > --- > > (Updated Dec. 1, 2016, 10:16 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-19045 > https://issues.apache.org/jira/browse/AMBARI-19045 > > > Repository: ambari > > > Description > --- > > Some unit tests for Date Mapper in the Log Feeder > (testMapperDate_patternWithoutYear_previousYearLog, > testMapperDate_patternWithoutYear_currentYearLog) make no sense, but fail in > December. Remove these tests. > Options > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperDateTest.java > 667c9ff > > Diff: https://reviews.apache.org/r/54249/diff/ > > > Testing > --- > > - > > > Thanks, > > Miklos Gergely > >
