Re: Review Request 61521: Fix raceconditions causing ambari-agent to hang/fail

2017-08-09 Thread Alejandro Fernandez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61521/#review182506
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 9, 2017, 10:35 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61521/
> ---
> 
> (Updated Aug. 9, 2017, 10:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-21688
> https://issues.apache.org/jira/browse/AMBARI-21688
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix two raceconditions:  
> First causes agent to hang forever during initial connection:
> 
> 
> 
> INFO 2017-08-08 16:55:06,780 transport.py:329 - Starting receiver 
> loopINFO 2017-08-08 16:55:06,781 transport.py:271 - Sending frame: 'STOMP', 
> headers={'host': 0, 'accept-version': '1.2'}
> 
> 
> Second one causes heartbeating fail with:
> 
> 
> 
> ERROR 2017-08-08 10:12:08,328 HeartbeatThread.py:167 - Error in 
> responseId sequence - restarting
> INFO 2017-08-08 10:12:08,328 ExitHelper.py:56 - Performing cleanup before 
> exiting...
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py d6cbdcc 
>   ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 
> be3eb5b 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py e2fe4af 
>   ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py c45b64a 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 9b031f7 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py
>  6d23c37 
>   ambari-agent/src/main/python/ambari_agent/security.py 9509619 
>   ambari-common/src/main/python/ambari_stomp/adapter/websocket.py 220f399 
>   ambari-common/src/main/python/ambari_ws4py/websocket.py b5c1fd3 
> 
> 
> Diff: https://reviews.apache.org/r/61521/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 61521: Fix raceconditions causing ambari-agent to hang/fail

2017-08-09 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61521/
---

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21688
https://issues.apache.org/jira/browse/AMBARI-21688


Repository: ambari


Description
---

Fix two raceconditions:  
First causes agent to hang forever during initial connection:



INFO 2017-08-08 16:55:06,780 transport.py:329 - Starting receiver loopINFO 
2017-08-08 16:55:06,781 transport.py:271 - Sending frame: 'STOMP', 
headers={'host': 0, 'accept-version': '1.2'}


Second one causes heartbeating fail with:



ERROR 2017-08-08 10:12:08,328 HeartbeatThread.py:167 - Error in responseId 
sequence - restarting
INFO 2017-08-08 10:12:08,328 ExitHelper.py:56 - Performing cleanup before 
exiting...


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py d6cbdcc 
  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py be3eb5b 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py e2fe4af 
  ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py c45b64a 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 9b031f7 
  
ambari-agent/src/main/python/ambari_agent/listeners/ServerResponsesListener.py 
6d23c37 
  ambari-agent/src/main/python/ambari_agent/security.py 9509619 
  ambari-common/src/main/python/ambari_stomp/adapter/websocket.py 220f399 
  ambari-common/src/main/python/ambari_ws4py/websocket.py b5c1fd3 


Diff: https://reviews.apache.org/r/61521/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk