Re: Review Request 62379: Fixes to CommandStatusDict

2017-09-18 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62379/#review185547
---


Ship it!




Ship It!

- Attila Doroszlai


On Sept. 18, 2017, 12:56 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62379/
> ---
> 
> (Updated Sept. 18, 2017, 12:56 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-21979
> https://issues.apache.org/jira/browse/AMBARI-21979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1\. Fix COMPLETE status for command sent twice  
> 2\. Fix possible race conditions  
> 3\. Add setting to avoid periodically reporting stdout/stderr. Can be used on
> perf clusters to reduce bandwidth usage for perf. Previously to do this
> reporting thread had to be stopped which caused issues with delayed commands
> status re-sending.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini e1df1d2 
>   ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 084a342 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py fa71d15 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py f46c47a 
>   ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 
> d074786c 
>   ambari-agent/src/main/python/ambari_agent/Constants.py e36eda5 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 4fbef65 
> 
> 
> Diff: https://reviews.apache.org/r/62379/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>



Review Request 62379: Fixes to CommandStatusDict

2017-09-18 Thread Andrew Onischuk

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62379/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21979
https://issues.apache.org/jira/browse/AMBARI-21979


Repository: ambari


Description
---

1\. Fix COMPLETE status for command sent twice  
2\. Fix possible race conditions  
3\. Add setting to avoid periodically reporting stdout/stderr. Can be used on
perf clusters to reduce bandwidth usage for perf. Previously to do this
reporting thread had to be stopped which caused issues with delayed commands
status re-sending.


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini e1df1d2 
  ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 084a342 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py fa71d15 
  ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py f46c47a 
  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py d074786c 
  ambari-agent/src/main/python/ambari_agent/Constants.py e36eda5 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 4fbef65 


Diff: https://reviews.apache.org/r/62379/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk