Re: Review Request 63880: VDF defined HDP-GPL repo should be tagged appropriately

2017-11-17 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63880/#review191321
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 16, 2017, 5:45 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63880/
> ---
> 
> (Updated Nov. 16, 2017, 5:45 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-22461
> https://issues.apache.org/jira/browse/AMBARI-22461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This adds tags to a repository for use by Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a6315f8350 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  5ec46f044f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3c10e43343 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  3ca81d7648 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  034f3bce6e 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> 81b4da949f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  bd53c11bd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoTag.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  79ace89380 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  a77caab32d 
>   ambari-server/src/main/resources/version_definition.xsd eaed31d582 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  c46cce708e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  6f33c7e8c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
>  70ff801eb3 
>   ambari-server/src/test/resources/version_definition_with_tags.xml 
> PRE-CREATION 
>   contrib/version-builder/version_builder.py 5bf54303ed 
> 
> 
> Diff: https://reviews.apache.org/r/63880/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4925, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO]
> 
> 
> Thanks,
> 
> Nate Cole
> 
>



Re: Review Request 63880: VDF defined HDP-GPL repo should be tagged appropriately

2017-11-16 Thread Jonathan Hurley

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63880/#review191207
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 16, 2017, 10:45 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63880/
> ---
> 
> (Updated Nov. 16, 2017, 10:45 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan 
> Hurley.
> 
> 
> Bugs: AMBARI-22461
> https://issues.apache.org/jira/browse/AMBARI-22461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This adds tags to a repository for use by Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a6315f8350 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  5ec46f044f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3c10e43343 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  3ca81d7648 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  034f3bce6e 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
> 81b4da949f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  bd53c11bd7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoTag.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  79ace89380 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  a77caab32d 
>   ambari-server/src/main/resources/version_definition.xsd eaed31d582 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
>  c46cce708e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
>  6f33c7e8c1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
>  70ff801eb3 
>   ambari-server/src/test/resources/version_definition_with_tags.xml 
> PRE-CREATION 
>   contrib/version-builder/version_builder.py 5bf54303ed 
> 
> 
> Diff: https://reviews.apache.org/r/63880/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4925, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO]
> 
> 
> Thanks,
> 
> Nate Cole
> 
>



Review Request 63880: VDF defined HDP-GPL repo should be tagged appropriately

2017-11-16 Thread Nate Cole

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63880/
---

Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan 
Hurley.


Bugs: AMBARI-22461
https://issues.apache.org/jira/browse/AMBARI-22461


Repository: ambari


Description
---

This adds tags to a repository for use by Ambari


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 a6315f8350 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
 5ec46f044f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 3c10e43343 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 3ca81d7648 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
 034f3bce6e 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
81b4da949f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
bd53c11bd7 
  ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepoTag.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
 79ace89380 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 a77caab32d 
  ambari-server/src/main/resources/version_definition.xsd eaed31d582 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
 c46cce708e 
  
ambari-server/src/test/java/org/apache/ambari/server/state/repository/VersionDefinitionTest.java
 6f33c7e8c1 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
 70ff801eb3 
  ambari-server/src/test/resources/version_definition_with_tags.xml 
PRE-CREATION 
  contrib/version-builder/version_builder.py 5bf54303ed 


Diff: https://reviews.apache.org/r/63880/diff/1/


Testing
---

Manual.  Unit tests pending.


Thanks,

Nate Cole