Re: Review Request 22082: Modify the way that config binding helpers get registered.

2014-06-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22082/ --- (Updated June 2, 2014, 10:40 a.m.) Review request for Aurora, Antoine Tollenaer

Re: Review Request 22092: Fixed syntax gotcha in .gitignore.

2014-06-02 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22092/ --- (Updated June 2, 2014, 6:06 p.m.) Review request for Aurora and Bill Farner.

Review Request 22154: Adding admin commands into aurora2 lib.

2014-06-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22154/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-502 https://is

Review Request 22158: aurora-0.5.1-dev1401738717 release.

2014-06-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22158/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur

Re: Review Request 22154: Adding admin commands into aurora2 lib.

2014-06-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22154/#review44542 --- Ship it! Ship It! - Mark Chu-Carroll On June 2, 2014, 2:46 p.m.,

Re: Review Request 22097: Remove unused thrift flags from scheduler

2014-06-02 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22097/#review44549 --- Ship it! Code change lgtm, although I can't speak for the impact of

Re: Review Request 22097: Remove unused thrift flags from scheduler

2014-06-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22097/#review44553 --- Ship it! Ship It! - Maxim Khutornenko On May 30, 2014, 10:52 p.m

Re: Review Request 21386: Add support for custom project to list-missing-shipits

2014-06-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21386/#review44554 --- Ship it! Ship It! - Kevin Sweeney On May 15, 2014, 10:28 a.m., D

Re: Review Request 22097: Remove unused thrift flags from scheduler

2014-06-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22097/#review44568 --- Please drop these as well: build.gradle 473:'-thrift_port=8082',

Re: Review Request 21402: Add python checkstyle hooks.

2014-06-02 Thread Brian Wickman
> On May 19, 2014, 7:04 p.m., Jake Farrell wrote: > > Looks good, thoughts on saving the output to a build log file rather than > > /dev/null and prompting to re-run on error? This is a good idea. I will do this in a subsequent review though, just to get this one over the finish line. - Bri

Review Request 22165: Fix python import order

2014-06-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22165/ --- Review request for Aurora and Mark Chu-Carroll. Repository: aurora Descriptio

Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman. Bugs

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22167/ --- (Updated June 3, 2014, 12:26 a.m.) Review request for Aurora, Joe Smith, Mark C

Review Request 22168: Make style consistent with build-support/python/checkstyle-check

2014-06-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22168/ --- Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Repository: auro