Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Bill Farner
On April 17, 2015, 5:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, lines 142-144 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142 ``` SetString allSlaves =

Re: Review Request 33366: Fix the path to download stdout/stderr

2015-04-21 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 6:53 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 33374: Resuming blocked updates on restart.

2015-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33374/#review81046 --- Ship it! Ship It! - Bill Farner On April 20, 2015, 10:19 p.m.,

Re: Review Request 33403: Upgrade to virtualenv 12.1.1

2015-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33403/ --- (Updated April 21, 2015, 6:35 p.m.) Review request for Aurora and Kevin

Re: Review Request 33366: Fix the path to download stdout/stderr

2015-04-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review81042 --- Ship it!

Re: Review Request 33366: Fix the path to download stdout/stderr

2015-04-21 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/ --- (Updated April 21, 2015, 7:53 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 33403: Upgrade to virtualenv 12.1.1

2015-04-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33403/#review81028 --- Ship it! LGTM if e2e tests pass - Kevin Sweeney On April 21,

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review81030 --- Ship it! LGTM overall, but i'd like to converge on the

Re: Review Request 33273: Add a specific storage routine for bulk loading data.

2015-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33273/#review81064 --- Ship it! Ship It! - Maxim Khutornenko On April 16, 2015, 9:50

Review Request 33411: Add typed Shiro permissions SPI.

2015-04-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 21, 2015, 9:15 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Maxim Khutornenko
On April 17, 2015, 5:59 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, lines 142-144 https://reviews.apache.org/r/32597/diff/5/?file=931268#file931268line142 ``` SetString allSlaves =

Re: Review Request 33366: Fix the path to download stdout/stderr

2015-04-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33366/#review81055 --- Ship it! I'd like to note that our best practice is to use

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-21 Thread Kevin Sweeney
On April 21, 2015, 3:27 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 60 https://reviews.apache.org/r/33411/diff/1/?file=938796#file938796line60 Is this used anywhere now? Nope, removed. On April 21, 2015,

Re: Review Request 33411: Add typed Shiro permissions SPI.

2015-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33411/#review81088 --- Ship it! Master (8ba1b11) is green with this patch.

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review81085 --- Ship it! Master (d10d2d1) is green with this patch.