Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-05-18 Thread Zameer Manji
On May 15, 2015, 6:17 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/config/__init__.py, lines 255-257 https://reviews.apache.org/r/34300/diff/1/?file=961839#file961839line255 Delete this property entirely rather than return a dummy value? Presumably anything accessing

Re: Review Request 33433: Revert Revert Make health check configurable

2015-05-18 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33433/#review84193 --- Can this be merged in now? - Brian Brazil On April 28, 2015,

Re: Review Request 34307: Upgrade pants to 0.0.32

2015-05-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34307/#review84211 --- Ship it! pants.ini

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84224 --- Ship it! Master (920263b) is green with this patch.

Review Request 34372: Place api_util.py inside a `pants_library` target.

2015-05-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34372/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1325

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
On May 18, 2015, 10:05 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java, line 204 https://reviews.apache.org/r/34373/diff/1/?file=963203#file963203line204 Special-casing the reconsiliation reason and not the others smells like trouble to

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/ --- (Updated May 18, 2015, 10:42 p.m.) Review request for Aurora, Ben Mahler and

Re: Review Request 34307: Upgrade pants to 0.0.32

2015-05-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34307/#review84212 --- Ship it! Ship It! - Joshua Cohen On May 16, 2015, 1:20 a.m.,

Re: Review Request 34372: Place api_util.py inside a `pants_library` target.

2015-05-18 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34372/#review84219 --- Ship it! Ship It! - Joshua Cohen On May 18, 2015, 9:05 p.m.,

Re: Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/#review84236 --- Ship it! Master (920263b) is green with this patch.

Review Request 34373: Exposing task reconciliation stats.

2015-05-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34373/ --- Review request for Aurora, Ben Mahler and Zameer Manji. Bugs: AURORA-1047