Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84990 --- Master (998993d) is red with this patch.

Re: Review Request 34566: Adding H2 management console.

2015-05-22 Thread Maxim Khutornenko
On May 21, 2015, 11:34 p.m., Kevin Sweeney wrote: Have you investigated using the [Console Servlet](http://www.h2database.com/html/tutorial.html) directly? Then we can use the Shiro filter directly and avoid adding another mechanism to configure security as well as avoid adding

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84992 --- src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 https://reviews.apache.org/r/34440/diff/2-3/?file=964680#file964680line186 Add @Positive here as well. Well, this can and should be 0 as well. We start

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 22, 2015, 8:56 p.m.) Review request for Aurora, Ben Mahler,

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/#review84999 --- Ship it! Master (998993d) is green with this patch.

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
On May 19, 2015, 11:48 p.m., Zameer Manji wrote: Does it make sense for the reconciler to run in parallel with the GC executor mechanism? It seems fine to me, but I would like some re-assurance here. Maxim Khutornenko wrote: GC executor is not adding anything when task

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Joshua Cohen
On May 22, 2015, 8:52 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 186 https://reviews.apache.org/r/34440/diff/2-3/?file=964680#file964680line186 Add @Positive here as well. Maxim Khutornenko wrote: Well, this can and

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-22 Thread Benjamin Staffin
On May 22, 2015, 5:47 p.m., Joe Smith wrote: debian/rules, line 38 https://reviews.apache.org/r/31101/diff/3/?file=966761#file966761line38 you can also [add the thermos cli tool](https://github.com/apache/aurora/blob/master/src/main/python/apache/thermos/cli/bin/BUILD#L15) oh

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-22 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/ --- (Updated May 22, 2015, 6:59 p.m.) Review request for Aurora and Jake Farrell.

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-22 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review85052 --- Ship it! Master (6db13ba) is green with this patch.

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-05-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review85038 --- Ship it! Ship It! - Joe Smith On May 19, 2015, 9:19 a.m., Steve

Re: Review Request 34501: Defaulting TemporaryStorage to in-memory task store.

2015-05-22 Thread Maxim Khutornenko
On May 20, 2015, 10:17 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java, lines 72-76 https://reviews.apache.org/r/34501/diff/1/?file=965743#file965743line72 How is the db storage going to graduate to production if it's not

Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.

2015-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34501/ --- (Updated May 23, 2015, 12:31 a.m.) Review request for Aurora and Kevin

Re: Review Request 34440: Implementing task reconciler.

2015-05-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34440/ --- (Updated May 22, 2015, 8:47 p.m.) Review request for Aurora, Ben Mahler,