Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review88983 --- Ship it! Master (2df2db9) is green with this patch.

Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1334

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-06-23 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review88987 --- Are you able to update this Steve? would love to get this in for

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review88977 --- This patch does not apply cleanly on master (2df2db9), do you need

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko
On June 23, 2015, 2:19 a.m., Zameer Manji wrote: src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java, line 69 https://reviews.apache.org/r/35760/diff/1/?file=990090#file990090line69 We can remove this test now that the gc executor is gone. Seems like a valid test to

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/ --- (Updated June 23, 2015, 2:24 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review89007 --- Ship it! LGTM so long as end-to-end tests come up green.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89008 --- LGTM overall, will give a ship once the rebase comes out green.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
On June 23, 2015, 5:55 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java, line 167 https://reviews.apache.org/r/35761/diff/1/?file=990578#file990578line167 Accessing the Impl suggests an encapsulagion problem. Can you use the

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner
On June 23, 2015, 6:58 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java, line 133 https://reviews.apache.org/r/35793/diff/2/?file=990668#file990668line133 Any particular reason you've settled on an explicit removal call as

Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1298

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/#review89022 ---

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89039 --- Ship it!

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/ --- (Updated June 23, 2015, 6:28 p.m.) Review request for Aurora and Maxim

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/ --- (Updated June 23, 2015, 6:35 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/#review89026 --- Ship it! Master (68c4620) is green with this patch.

Re: Review Request 35760: Removing GcExecutorLauncher code.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35760/#review89016 --- Ship it! Master (2df2db9) is green with this patch.

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/#review89023 --- Ship it! Master (68c4620) is green with this patch.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35761/ --- (Updated June 23, 2015, 8:39 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35761: Refactoring TaskLauncher.

2015-06-23 Thread Maxim Khutornenko
On June 23, 2015, 7:46 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, line 242 https://reviews.apache.org/r/35761/diff/2/?file=990689#file990689line242 s/manager/handler/ Done. - Maxim

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35793/#review89047 --- Discussed with Bill offline and it seems like having an offline

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88946 --- Ship it! Master (2df2db9) is green with this patch.

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko
On June 24, 2015, 12:31 a.m., Brian Wickman wrote: slightly overzealous deleting. the thermos gc stuff should still be part of the thermos toolchain. Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not seem to be a critical feature (in

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko
On June 24, 2015, 12:31 a.m., Brian Wickman wrote: slightly overzealous deleting. the thermos gc stuff should still be part of the thermos toolchain. Maxim Khutornenko wrote: Should not we rather rely on task reconciliation to do any cleanup instead? Force GCing a task does not

Re: Review Request 35793: DbTaskStore: delete unreferenced job keys.

2015-06-23 Thread Bill Farner
On June 23, 2015, 8:12 p.m., Maxim Khutornenko wrote: Discussed with Bill offline and it seems like having an offline periodic async GC processor would be a better long term solution. It would allow us to handle all cleanup in a single place but more importantly will remove the

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89108 --- Ship it! Master (4b8c34c) is green with this patch.

Review Request 35812: Remove enable_legacy_constraints flag.

2015-06-23 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35812/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs:

Review Request 35813: Removing GC executor code.

2015-06-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-1333

Re: Review Request 35813: Removing GC executor code.

2015-06-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35813/#review89104 --- slightly overzealous deleting. the thermos gc stuff should still