Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 6:11 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90587 --- Ship it! Ship It! - Bill Farner On July 6, 2015, 9:41 p.m.,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Bill Farner
On July 6, 2015, 9:56 p.m., Bill Farner wrote: Ship It! I got as far as successfully building and installing all created RPMs. I did not go much beyond that as far as qualification - aside from auccessfully running `aurora` and starting up the scheduler. Thanks for the patch! - Bill

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90542 --- Ship it! Master (318b40d) is green with this patch.

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 7:25 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:09 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/#review90523 --- Ship it! +1 to this tactical fix. Which APIs need to be changed to

Review Request 36220: Change docs to use a working git repo URL.

2015-07-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36220/ --- Review request for Aurora and Jake Farrell. Bugs: AURORA-1382

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90567 --- Ship it! Master (318b40d) is green with this patch.

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 9:05 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90560 --- Ship it! Master (318b40d) is green with this patch.

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/#review90535 --- Ship it! Master (318b40d) is green with this patch.

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36096/ --- (Updated July 6, 2015, 6:42 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 34020: Normalize SLA stat names

2015-07-06 Thread Bill Farner
On July 5, 2015, 7:49 p.m., Stephan Erb wrote: The same thing should also be applied to https://github.com/apache/aurora/blob/827b9abea48babe53ad5b2c521757c60f04c6dfc/src/main/java/org/apache/aurora/scheduler/TaskVars.java#L110 Good call - are you planning to roll that into this patch?

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90531 --- Ship it! Master (318b40d) is green with this patch.

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
On July 6, 2015, 9:20 p.m., Kevin Sweeney wrote: build-support/packaging/rpm/aurora.service, line 20 https://reviews.apache.org/r/33778/diff/12/?file=1000455#file1000455line20 This is unnecessary according to [1]? Alternatively you should consider doing `curl -X POST

Re: Review Request 36220: Change docs to use a working git repo URL.

2015-07-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36220/#review90580 --- Ship it! Ship It! - Kevin Sweeney On July 6, 2015, 2:37 p.m.,

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90566 --- build-support/packaging/rpm/aurora.service (line 20)

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Steve Salevan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/ --- (Updated July 6, 2015, 8:40 p.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

2015-07-06 Thread Bill Farner
On July 6, 2015, 6:31 p.m., Kevin Sweeney wrote: +1 to this tactical fix. Which APIs need to be changed to use slaveID instead of hostName as the canonical identifier for mesos slaves within aurora? I'd approach bottom-up, starting with `AttributeStore#getHostAttributes()`. Most

Re: Review Request 33778: Adds RPM specfile and support scripting

2015-07-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33778/#review90592 --- Ship it! Master (60ef7f6) is green with this patch.