Review Request 36459: Fix AuroraConfigLoader schema filtering when loading from string.

2015-07-13 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36459/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
On July 13, 2015, 3:04 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java, line 14 https://reviews.apache.org/r/36407/diff/1/?file=1008771#file1008771line14 Why not move this class to org.apache.aurora.util? Nothing about this

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
On July 13, 2015, 3:04 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java, line 40 https://reviews.apache.org/r/36407/diff/1/?file=1008765#file1008765line40 Some db view classes provide methods to convert to the immutable

Re: Review Request 36459: Fix AuroraConfigLoader schema filtering when loading from string.

2015-07-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36459/#review91563 --- Ship it! Master (b7a02a5) is green with this patch.

Re: Review Request 36459: Fix AuroraConfigLoader schema filtering when loading from string.

2015-07-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36459/#review91555 --- Master (b7a02a5) is red with this patch.

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-13 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/ --- (Updated July 13, 2015, 4:10 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-13 Thread Joe Smith
On July 12, 2015, 11:38 p.m., Stephan Erb wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 169 https://reviews.apache.org/r/36436/diff/1/?file=1009204#file1009204line169 Give that this will be the only documentation of this feature, the

Re: Review Request 36459: Fix AuroraConfigLoader schema filtering when loading from string.

2015-07-13 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36459/ --- (Updated July 13, 2015, 11:11 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36407/#review91559 --- Ship it! Ship It! - Zameer Manji On July 10, 2015, 3:47 p.m.,

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91561 --- Ship it! Master (b7a02a5) is green with this patch.

Review Request 36456: Upgrade isort version, which is less verbose by default.

2015-07-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36456/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-1397

Re: Review Request 36387: Fix JDBC URL.

2015-07-13 Thread Bill Farner
On July 13, 2015, 10:09 p.m., Zameer Manji wrote: Is it not possible for an integration test to catch this issue? Not in a straightforward way. The ultimate outcome would be flakiness in tests, where the DB would auto-close early and subsequent queries would fail. - Bill

Re: Review Request 36456: Upgrade isort version, which is less verbose by default.

2015-07-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36456/#review91549 --- Ship it! Master (190daed) is green with this patch.

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36407/#review91538 --- Overall LGTM, just two issues to discuss.

Re: Review Request 36387: Fix JDBC URL.

2015-07-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36387/#review91541 --- Ship it! Is it not possible for an integration test to catch this

Re: Review Request 36456: Upgrade isort version, which is less verbose by default.

2015-07-13 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36456/#review91545 --- Ship it! - Brian Brazil On July 13, 2015, 10:15 p.m., Bill

Re: Review Request 36407: Introduce DB entity objects and avoid ugly hacks around mybatis/thrift issues.

2015-07-13 Thread Bill Farner
On July 13, 2015, 10:04 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/db/shims/TaskConstraintShim.java, line 40 https://reviews.apache.org/r/36407/diff/1/?file=1008765#file1008765line40 Some db view classes provide methods to convert to the immutable

Re: Review Request 36436: Prevent job updates from allowing unbounded instance events

2015-07-13 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36436/#review91416 ---