Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93722 --- Seems reasonable to me. We should definitely add some documentation

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93731 --- src/main/python/apache/aurora/admin/BUILD

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93744 --- lgtm at a high level. src/main/python/apache/aurora/common/BUILD

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
On July 31, 2015, 9:01 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/admin/BUILD, lines 84-92 https://reviews.apache.org/r/36972/diff/2/?file=1025863#file1025863line84 Are we completely abondoning the idea of having a non-kerberized client version with this? This

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93756 --- Master (d327773) is green with this patch.

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Bill Farner
On July 31, 2015, 4:01 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/admin/BUILD, lines 84-92 https://reviews.apache.org/r/36972/diff/2/?file=1025863#file1025863line84 Are we completely abondoning the idea of having a non-kerberized client version with this? This

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
On July 31, 2015, 7:39 a.m., Joshua Cohen wrote: src/main/python/apache/thermos/bin/BUILD, line 40 https://reviews.apache.org/r/36972/diff/2/?file=1025877#file1025877line40 Should this read from .auroraversion? Good catch! (leftover from my example email). Fixed. - Kevin

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 11:03 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 36289: Custom executor support for Scheduler

2015-07-31 Thread Meghdoot Bhattacharya
On July 15, 2015, 7:08 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/app/ExecutorSettingsLoader.java, line 57 https://reviews.apache.org/r/36289/diff/2/?file=1011919#file1011919line57 Please model your configuration as an object, and let Gson do the heavy

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 10:56 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
On July 31, 2015, 10:19 a.m., Brian Wickman wrote: src/main/python/apache/aurora/common/BUILD, line 61 https://reviews.apache.org/r/36972/diff/2/?file=1025868#file1025868line61 This is probably the toughest one to swallow. Pulling in aurora.common just for aurora_job_key now

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Bill Farner
On July 31, 2015, 4:01 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/admin/BUILD, lines 84-92 https://reviews.apache.org/r/36972/diff/2/?file=1025863#file1025863line84 Are we completely abondoning the idea of having a non-kerberized client version with this? This

Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36998/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1409

Re: Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36998/#review93775 --- Ship it! Master (d327773) is green with this patch.

Review Request 36994: Splitting TaskGroups related tests from TaskSchedulerTest

2015-07-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36994/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

2015-07-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36998/#review93779 --- Ship it! Ship It! - Maxim Khutornenko On July 31, 2015, 8:36

Re: Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

2015-07-31 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36998/#review93780 --- Ship it! Ship It! - Bill Farner On July 31, 2015, 8:36 p.m.,

Re: Review Request 36994: Splitting TaskGroups related tests from TaskSchedulerTest

2015-07-31 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36994/#review93781 --- Ship it! LGTM once the summary is updated to reflect the change.

Re: Review Request 36994: Adding missing coverage in TaskGroups

2015-07-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36994/ --- (Updated July 31, 2015, 9:21 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93793 --- I think it makes sense to split into two binary-exporting packages:

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 3:30 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
On July 31, 2015, 3:21 p.m., Brian Wickman wrote: I think it makes sense to split into two binary-exporting packages: one client-side and one server-side. The client side (aurora.client) should contain aurora client and aurora admin client. The server-side (reuse aurora.executor?)

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93794 --- Master (6cab9c5) is green with this patch.

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93799 --- Master (6cab9c5) is green with this patch.

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
On July 31, 2015, 10:57 p.m., Joshua Cohen wrote: I'm -1 to shipping without something under docs/ explaining this organizational structure. Bill Farner wrote: maybe a README.md under `src/main/python/apache` instead? Kevin Sweeney wrote: I've added a new file

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93829 --- Ship it! Ship It! - Joshua Cohen On July 31, 2015, 11:22 p.m.,

Review Request 37001: Centralizing offer/task matching in TaskAssigner.

2015-07-31 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37001/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1416

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Bill Farner
On July 31, 2015, 10:57 p.m., Joshua Cohen wrote: I'm -1 to shipping without something under docs/ explaining this organizational structure. maybe a README.md under `src/main/python/apache` instead? - Bill --- This is an

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 4:18 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
On July 31, 2015, 3:57 p.m., Joshua Cohen wrote: I'm -1 to shipping without something under docs/ explaining this organizational structure. Bill Farner wrote: maybe a README.md under `src/main/python/apache` instead? I've added a new file docs/build-system.md - Kevin

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 4:22 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37001: Centralizing offer/task matching in TaskAssigner.

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37001/#review93816 --- Ship it! Master (a45a8ee) is green with this patch.

Re: Review Request 37001: Centralizing offer/task matching in TaskAssigner.

2015-07-31 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37001/#review93817 --- Ship it! - Bill Farner On July 31, 2015, 11:03 p.m., Maxim

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93805 --- I'm -1 to shipping without something under docs/ explaining this

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 3:49 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93818 --- Master (a45a8ee) is green with this patch.

Re: Review Request 36994: Splitting TaskGroups related tests from TaskSchedulerTest

2015-07-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36994/#review93777 --- Ship it! Master (d327773) is green with this patch.

Re: Review Request 36972: One python_library per exported setup.py project

2015-07-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/ --- (Updated July 31, 2015, 3:03 p.m.) Review request for Aurora, Bill Farner and