Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-08-03 Thread George Sirois
> On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example, i

Review Request 37041: Remove defunct scheduler-local.sh.

2015-08-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37041/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 37041: Remove defunct scheduler-local.sh.

2015-08-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37041/#review93915 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 3, 2015, 4:35 p.m.

Re: Review Request 37001: Centralizing offer/task matching in TaskAssigner.

2015-08-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37001/#review93922 --- Ship it! src/main/java/org/apache/aurora/scheduler/scheduling/Task

Re: Review Request 37001: Centralizing offer/task matching in TaskAssigner.

2015-08-03 Thread Maxim Khutornenko
> On Aug. 3, 2015, 5:38 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java, > > line 111 > > > > > > nit: Was it needed to flip the BiCache type here? If not, it wo

Re: Review Request 36972: One python_library per exported setup.py project

2015-08-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93930 --- Ship it! Ship It! - Bill Farner On Aug. 1, 2015, 10:38 p.m., Kev

Re: Review Request 36972: One python_library per exported setup.py project

2015-08-03 Thread Brian Wickman
> On July 31, 2015, 10:21 p.m., Brian Wickman wrote: > > I think it makes sense to split into two binary-exporting packages: one > > client-side and one server-side. The client side (aurora.client) should > > contain aurora client and aurora admin client. The server-side (reuse > > aurora.exe

Re: Review Request 36972: One python_library per exported setup.py project

2015-08-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93932 --- Ship it! - Brian Wickman On Aug. 1, 2015, 10:38 p.m., Kevin Sween

Re: Review Request 36972: One python_library per exported setup.py project

2015-08-03 Thread Kevin Sweeney
> On July 31, 2015, 3:21 p.m., Brian Wickman wrote: > > I think it makes sense to split into two binary-exporting packages: one > > client-side and one server-side. The client side (aurora.client) should > > contain aurora client and aurora admin client. The server-side (reuse > > aurora.exec

Re: Review Request 36874: Fix typo in the scheduler deployment documentation

2015-08-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36874/#review93943 --- ping - Kevin Sweeney On July 27, 2015, 8:01 p.m., Kevin Sweeney w

Re: Review Request 36874: Fix typo in the scheduler deployment documentation

2015-08-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36874/#review93944 --- Ship it! Ship It! - Maxim Khutornenko On July 28, 2015, 3:01 a.m

Review Request 37047: Build Kerberos clients in RPM.

2015-08-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37047/ --- Review request for Aurora, Steve Salevan and Bill Farner. Bugs: AURORA-1410

Re: Review Request 37047: Build Kerberos clients in RPM.

2015-08-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37047/#review93949 --- Ship it! Thanks! I can fix any rough edges this week as i wrap up

Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1395 https://issu

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review93976 --- src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review93983 --- Ship it! Master (7fdcfef) is green with this patch. ./build-suppo