Re: Review Request 37764: Update packages for post 0.9.0 changes.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37764/ --- (Updated Aug. 25, 2015, 10:38 a.m.) Review request for Aurora and Maxim

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96377 --- Ship it! Ship It! - Zameer Manji On Aug. 25, 2015, 8:01 a.m.,

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96362 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 25, 2015, 3:01

Review Request 37764: Update packages for post 0.9.0 changes.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37764/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-851

Re: Review Request 37764: Update packages for post 0.9.0 changes.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37764/#review96374 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 25, 2015, 5:38

Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs:

Re: Review Request 37742: Remove use of host attributes from e2e tests.

2015-08-25 Thread Maxim Khutornenko
On Aug. 25, 2015, 3:31 a.m., Maxim Khutornenko wrote: src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, lines 45-48 https://reviews.apache.org/r/37742/diff/1/?file=1049818#file1049818line45 I am a bit concerned we will no longer have any constraint coverage in our e2e

Re: Review Request 37772: Fix RPM building.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/ --- (Updated Aug. 25, 2015, 9:38 p.m.) Review request for Aurora and Maxim

Re: Review Request 37772: Fix RPM building.

2015-08-25 Thread Bill Farner
On Aug. 25, 2015, 4:12 p.m., Kevin Sweeney wrote: specs/rpm/Makefile, lines 37-38 https://reviews.apache.org/r/37772/diff/1/?file=1052463#file1052463line37 This is weird as a user will never be able to upgrade from a release version to a nightly. Maxim Khutornenko wrote:

Re: Review Request 37772: Fix RPM building.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/#review96494 --- Ship it! specs/rpm/aurora.spec (lines 62 - 72)

Review Request 37788: Deb: Clean up changelog generation.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37788/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora-packaging

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96399 --- Master (86a547b) is green with this patch.

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96394 --- What if they click on an old update and the instance page doesn't

Re: Review Request 37719: Revocable: schema changes.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/ --- (Updated Aug. 25, 2015, 10:28 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Joshua Cohen
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote: What if they click on an old update and the instance page doesn't reflect the change made in this instance event? Do we care? I don't think we care, there's not much we can do in that case, is there? The only thing I can think of is

Re: Review Request 37770: Replace Twitter copyright headers in commons.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37770/#review96420 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 1:16 p.m.,

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Joshua Cohen
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote: What if they click on an old update and the instance page doesn't reflect the change made in this instance event? Do we care? Joshua Cohen wrote: I don't think we care, there's not much we can do in that case, is there? The

Re: Review Request 37776: Setting revocable flag on a TaskInfo.

2015-08-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37776/#review96459 --- Ship it! Master (96a086c) is green with this patch.

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Maxim Khutornenko
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote: What if they click on an old update and the instance page doesn't reflect the change made in this instance event? Do we care? Joshua Cohen wrote: I don't think we care, there's not much we can do in that case, is there? The

Re: Review Request 37774: Adding TierManager binding into JMH benchmarks.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37774/#review96439 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 3:16 p.m.,

Re: Review Request 37772: Fix RPM building.

2015-08-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/#review96443 --- specs/rpm/Makefile (lines 37 - 38)

Re: Review Request 37772: Fix RPM building.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/#review96450 --- specs/rpm/Makefile (line 33)

Re: Review Request 37719: Revocable: schema changes.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37719/#review96438 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 3:28 p.m.,

Review Request 37776: Setting revocable flag on a TaskInfo.

2015-08-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37776/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora

Re: Review Request 37772: Fix RPM building.

2015-08-25 Thread Maxim Khutornenko
On Aug. 25, 2015, 11:12 p.m., Kevin Sweeney wrote: specs/rpm/Makefile, lines 37-38 https://reviews.apache.org/r/37772/diff/1/?file=1052463#file1052463line37 This is weird as a user will never be able to upgrade from a release version to a nightly. Isn't version global across RPM

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread David McLaughlin
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote: What if they click on an old update and the instance page doesn't reflect the change made in this instance event? Do we care? Joshua Cohen wrote: I don't think we care, there's not much we can do in that case, is there? The

Review Request 37772: Fix RPM building.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37772/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-851

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread Joshua Cohen
On Aug. 25, 2015, 6:42 p.m., David McLaughlin wrote: What if they click on an old update and the instance page doesn't reflect the change made in this instance event? Do we care? Joshua Cohen wrote: I don't think we care, there's not much we can do in that case, is there? The

Re: Review Request 37761: Add a link to the instance page from instance events on the update page.

2015-08-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37761/#review96479 --- Ship it! Ship It! - David McLaughlin On Aug. 25, 2015, 3:01

Re: Review Request 37776: Setting revocable flag on a TaskInfo.

2015-08-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37776/#review96480 --- Ship it! Ship It! - Bill Farner On Aug. 25, 2015, 4:05 p.m.,