Re: Review Request 37825: Adding minimal implementation of the external tier config.

2015-08-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37825/#review97027 --- Ship it! src/main/java/org/apache/aurora/scheduler/SchedulerModule

Review Request 37933: Remove dependency on old google testing library.

2015-08-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37933/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description --

Re: Review Request 37933: Remove dependency on old google testing library.

2015-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37933/#review97030 --- Ship it! Master (782f883) is green with this patch. ./build-suppo

Re: Review Request 37933: Remove dependency on old google testing library.

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37933/#review97033 --- Ship it! Nice! - Zameer Manji On Aug. 30, 2015, 9:35 a.m., Bill

Re: Review Request 37874: Remove unused code from commons fork.

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/#review97034 --- Ship it! commons/src/main/java/org/apache/aurora/common/zookeeper/

Re: Review Request 37874: Remove unused code from commons fork.

2015-08-30 Thread Bill Farner
> On Aug. 30, 2015, 10:53 a.m., Zameer Manji wrote: > > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java, > > line 599 > > > > > > Please update (or delete) the JavaDoc here. Thanks, fixe

Re: Review Request 37874: Remove unused code from commons fork.

2015-08-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/ --- (Updated Aug. 30, 2015, 2:34 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 37874: Remove unused code from commons fork.

2015-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37874/#review97039 --- Ship it! Master (782f883) is green with this patch. ./build-suppo

Review Request 37936: Upgrade to Guava 18

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-586 https://issues.

Re: Review Request 37936: Upgrade to Guava 18

2015-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/#review97047 --- Master (4899e2d) is green with this patch. ./build-support/jenkins

Re: Review Request 37936: Upgrade to Guava 18

2015-08-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/#review97050 --- Ship it! commons/src/main/java/org/apache/aurora/common/net/http/h

Re: Review Request 37936: Upgrade to Guava 18

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37936/ --- (Updated Aug. 30, 2015, 7:26 p.m.) Review request for Aurora and Bill Farner.

Review Request 37937: Remove barely used commons classes.

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 37937: Remove barely used commons classes.

2015-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/#review97054 --- Master (68447b3) is green with this patch. ./build-support/jenkins

Re: Review Request 37937: Remove barely used commons classes.

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/ --- (Updated Aug. 30, 2015, 9:37 p.m.) Review request for Aurora and Bill Farner.

Review Request 37938: Upgrade Shiro to 1.2.4.

2015-08-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37938/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1186 https://issu

Re: Review Request 37937: Remove barely used commons classes.

2015-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/#review97055 --- Master (68447b3) is green with this patch. ./build-support/jenkins

Re: Review Request 37938: Upgrade Shiro to 1.2.4.

2015-08-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37938/#review97056 --- Ship it! Master (68447b3) is green with this patch. ./build-suppo

Re: Review Request 37937: Remove barely used commons classes.

2015-08-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37937/#review97057 --- Ship it! Awesome! - Bill Farner On Aug. 30, 2015, 9:37 p.m., Zam

Re: Review Request 37938: Upgrade Shiro to 1.2.4.

2015-08-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37938/#review97058 --- Ship it! Ship It! - Bill Farner On Aug. 30, 2015, 9:49 p.m., Zam