Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Maxim Khutornenko
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97664 --- Ship it! I think there should be a `NEWS` file entry about this

Review Request 38106: Make it possible to link directly to individual tabs on the job page.

2015-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-696

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Suman Karumuri
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.

2015-09-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97669 --- Master (f3cbc39) is green with this patch.

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Suman Karumuri
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Maxim Khutornenko
> On Sept. 3, 2015, 1:27 a.m., Suman Karumuri wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 369 > > > > > > I think it will be better if we split this into > > nonProdSharedConsumption and

Re: Review Request 38081: Dropping quota check for dedicated jobs and exposing dedicated consumption.

2015-09-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38081/#review97675 --- Ship it! Ship It! - Joshua Cohen On Sept. 3, 2015, 12:46 a.m.,

Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.

2015-09-03 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97678 --- Ship it! Ship It! - David McLaughlin On Sept. 3, 2015, 7:14

Review Request 38111: Disable mimetype guessing in the observer chroot browser.

2015-09-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38111/ --- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1479

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-03 Thread Renan DelValle
> On Sept. 2, 2015, 4:45 p.m., Bill Farner wrote: > > examples/vagrant/executors-config.json, lines 4-7 > > > > > > The code later converts this array into a single command string. I > > suggest we just make this a

Re: Review Request 38014: Remove StartupRegistry.

2015-09-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/ --- (Updated Sept. 3, 2015, 4:38 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 3, 2015, 4:38 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 38014: Remove StartupRegistry.

2015-09-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38014/#review97698 --- This patch does not apply cleanly on master (9c0b1b2), do you need

Re: Review Request 38111: Disable mimetype guessing in the observer chroot browser.

2015-09-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38111/#review97697 --- Master (9c0b1b2) is green with this patch.

Re: Review Request 38111: Disable mimetype guessing in the observer chroot browser.

2015-09-03 Thread Zameer Manji
> On Sept. 3, 2015, 4:03 p.m., Kevin Sweeney wrote: > > Are you sure this works? AIUI it's Transfer-Encoding: gzip that we need to > > worry about, not content-encoding (which is part of the entity being > > served). Most web frameworks have a facility whereby they will locate > >

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review97695 --- Ship it! Master (9c0b1b2) is green with this patch.

Re: Review Request 38111: Disable mimetype guessing in the observer chroot browser.

2015-09-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38111/#review97691 --- Are you sure this works? AIUI it's Transfer-Encoding: gzip that we

Re: Review Request 38106: Make it possible to link directly to individual tabs on the job page.

2015-09-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38106/#review97673 --- Ship it! Ship It! - Zameer Manji On Sept. 3, 2015, 12:14 p.m.,