Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39631/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs:

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39631/#review103943 --- Master (84b9d4a) is red with this patch.

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39631/#review103962 --- Ship it! LGTM once build is green. - Bill Farner On Oct. 24,

Re: Review Request 39630: Explicitly declare FindBugs version and effort level.

2015-10-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39630/#review103963 --- Ship it! Ship It! - Bill Farner On Oct. 24, 2015, 9:44 p.m.,

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39631/ --- (Updated Oct. 25, 2015, 1:44 p.m.) Review request for Aurora, Maxim

Re: Review Request 39631: Add listener to trigger scheduler shutdown on service failure.

2015-10-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39631/#review103967 --- Master (7c25ef9) is green with this patch.

Re: Review Request 39633: Remove Connection interface

2015-10-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39633/#review103968 --- Ship it! Master (7c25ef9) is green with this patch.

Re: Review Request 39633: Remove Connection interface

2015-10-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39633/#review103970 --- Ship it! Ship It! - Bill Farner On Oct. 25, 2015, 1:58 p.m.,

Re: Review Request 39629: Remove ChainedPathDetector and root argument from the observer.

2015-10-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39629/#review103969 --- Ship it! Ship It! - Bill Farner On Oct. 24, 2015, 9:33 p.m.,