Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110725 --- Drive-by

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110738 --- Ship it! Ship It! - Joshua Cohen On Dec. 16, 2015, 7:53 p.m.,

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110739 --- Ship it! Ship It! - John Sirois On Dec. 16, 2015, 12:53 p.m.,

Re: Review Request 41226: Handling task event race in updater.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41226/#review110696 --- Ship it! Master (fb8155d) is green with this patch. true I

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110712 ---

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110742 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
> On Dec. 16, 2015, 11:29 a.m., John Sirois wrote: > > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java, line > > 148 > > > > > > It looks like this can be an NPE without advanced knowledge of

Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Bill Farner
> On Dec. 15, 2015, 8:45 p.m., Maxim Khutornenko wrote: > > Please, cleanup docs as well. There are quite a few "aurora job update" > > mentions. Thanks for catching that. Done. - Bill --- This is an automatically generated e-mail.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110727 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/ --- (Updated Dec. 16, 2015, 11:53 a.m.) Review request for Aurora and Joshua

Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/ --- (Updated Dec. 16, 2015, 12:20 p.m.) Review request for Aurora, Maxim

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110684 --- Master (fb8155d) is red with this patch.

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review110698 --- This patch does not apply cleanly on master (fb8155d), do you need

Re: Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/#review110723 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110718 --- Master (fb8155d) is red with this patch.

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110682 --- @ReviewBot retry Trying again. - Kasisnu Singh On Dec. 16,

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Maxim Khutornenko
> On Dec. 16, 2015, 4:22 p.m., Joshua Cohen wrote: > > I'd like to propose an alternate configuration schema for consideration. I > > feel like the version presented in this review is redundant and tries to > > shoehorn the "endpoint" concept onto a shell health checker where it > > doesn't

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review110693 --- Master (fb8155d) is green with this patch. true However, it

Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110695 --- Ship it! Master (fb8155d) is green with this patch. true I

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review110697 --- Ship it! Master (fb8155d) is green with this patch. true I

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110692 --- Ship it! Master (fb8155d) is green with this patch. true I

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Bill Farner
> On Dec. 16, 2015, 8:22 a.m., Joshua Cohen wrote: > > I'd like to propose an alternate configuration schema for consideration. I > > feel like the version presented in this review is redundant and tries to > > shoehorn the "endpoint" concept onto a shell health checker where it > > doesn't

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110716 --- I won't be able to give a review in a reasonable period of time.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/ --- (Updated Dec. 16, 2015, 7:08 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40889: Changed mesos native lib to use mesos.executor instead

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40889/#review110707 --- This patch does not apply cleanly on master (fb8155d), do you need

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review110710 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41226: Handling task event race in updater.

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41226/#review110715 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110722 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 40922: Thermos: Add ability to forward process output to stdout

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40922/#review110706 --- Ship it! Master (fb8155d) is green with this patch.

Review Request 41453: HTTP server cleanup - shut down the server after unit tests, remove jetty bug workaround.

2015-12-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41453/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description

Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110719 --- Ship it! Awesome! - Zameer Manji On Dec. 14, 2015, 2:36 p.m.,

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Joshua Cohen
> On Dec. 16, 2015, 4:22 p.m., Joshua Cohen wrote: > > I'd like to propose an alternate configuration schema for consideration. I > > feel like the version presented in this review is redundant and tries to > > shoehorn the "endpoint" concept onto a shell health checker where it > > doesn't

Re: Review Request 41368: Remove the client-side updater.

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41368/#review110717 --- Ship it! Master (fb8155d) is green with this patch.

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
> On Dec. 16, 2015, 4:22 p.m., Joshua Cohen wrote: > > I'd like to propose an alternate configuration schema for consideration. I > > feel like the version presented in this review is redundant and tries to > > shoehorn the "endpoint" concept onto a shell health checker where it > > doesn't

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110741 --- src/main/python/apache/aurora/client/config.py (line 103)

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/#review110794 --- This patch does not apply cleanly on master (3e1f823), do you need

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110791 --- Ship it! Master (3e1f823) is green with this patch.

Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-16 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/ --- Review request for Aurora. Repository: aurora Description --- Patch to

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/ --- (Updated Dec. 16, 2015, 10:43 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Dmitriy Shirchenko
> On Dec. 16, 2015, 10:14 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/config.py, lines 111-113 > > > > > > Nit, could probably inline all of this: > > > > if not

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Joshua Cohen
> On Dec. 16, 2015, 10:14 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/client/test_config.py, line 187 > > > > > > Kill this comment? It seems superfluous. > > Dmitriy Shirchenko wrote: > I added

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110828 --- src/main/python/apache/aurora/executor/common/health_checker.py

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/#review110816 --- Master (3e1f823) is green with this patch.

Re: Review Request 41473: Accept a command line argument for an executor configuration via json

2015-12-16 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41473/ --- (Updated Dec. 17, 2015, 12:34 a.m.) Review request for Aurora. Changes

Re: Review Request 41428: Refactoring HealthCheckConfig into separate structs

2015-12-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41428/#review110672 --- I'd like to propose an alternate configuration schema for

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 16, 2015, 4:38 p.m.) Review request for Aurora. Changes

Re: Review Request 41201: Preserve env variables for tasks in docker

2015-12-16 Thread Kasisnu Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/ --- (Updated Dec. 16, 2015, 4:41 p.m.) Review request for Aurora. Repository: