Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119428 --- Ship it! Great catch! One minor nitpick below.

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119457 --- Ship it! Ship It! - John Sirois On Feb. 16, 2016, 8:42

Re: Review Request 43622: Updating scheduler backup restore instructions.

2016-02-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43622/#review119459 --- I'd likewise like to run through the updated doc to confirm.

Re: Review Request 43643: Do not materialize set inside DbTaskStore#fetchTasks

2016-02-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43643/#review119484 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 17, 2016,

Re: Review Request 39073: Generalize plugin interface for aurora client.

2016-02-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39073/#review119544 --- I believe this is quite useful. Brian, any interest in reviving

Review Request 43669: AURORA-1616: [part 1] refactor tier management initialization to make it pluggable in tests.

2016-02-17 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43669/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository:

Re: Review Request 43669: AURORA-1616: [part 1] refactor tier management initialization to make it pluggable in tests.

2016-02-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43669/#review119548 --- Master (9d642dc) is red with this patch.

Re: Review Request 43669: AURORA-1616: [part 1] refactor tier management initialization to make it pluggable in tests.

2016-02-17 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43669/ --- (Updated Feb. 17, 2016, 3:37 p.m.) Review request for Aurora, Maxim

Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport

2016-02-17 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42656/ --- (Updated Feb. 18, 2016, 12:01 a.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 42656: Don't destroy session between requests with TRequestsTransport

2016-02-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42656/#review119561 --- Master (9d642dc) is red with this patch.