Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Joshua Cohen
> On March 21, 2016, 7:35 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 218 > > > > > > Couldn't find what it maps to in DB, is it not saved? > > Joshua Cohen wrote:

Re: Review Request 45055: Fix flickering of the Aurora logo on refresh.

2016-03-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45055/ --- (Updated March 22, 2016, 12:12 a.m.) Review request for Aurora and Joshua

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124658 --- Ship it! Ship It! - Maxim Khutornenko On March 21, 2016,

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Maxim Khutornenko
> On March 21, 2016, 7:35 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 218 > > > > > > Couldn't find what it maps to in DB, is it not saved? > > Joshua Cohen wrote:

Re: Review Request 45055: Fix flickering of the Aurora logo on refresh.

2016-03-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45055/ --- (Updated March 22, 2016, 12:17 a.m.) Review request for Aurora and Joshua

Re: Review Request 45115: AURORA-1642: Thermos runner finalization broken.

2016-03-21 Thread Amol Deshmukh
> On March 21, 2016, 12:28 p.m., Joshua Cohen wrote: > > Does anyone think it would make sense to add a task w/ a final process to > > the e2e suite to avoid future breakages like this in the future? > > Maxim Khutornenko wrote: > +1. Given how much time it took us to investigate, it would

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Maxim Khutornenko
> On March 21, 2016, 7:35 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 218 > > > > > > Couldn't find what it maps to in DB, is it not saved? > > Joshua Cohen wrote:

Re: Review Request 45115: AURORA-1642: Thermos runner finalization broken.

2016-03-21 Thread Maxim Khutornenko
> On March 21, 2016, 7:28 p.m., Joshua Cohen wrote: > > Does anyone think it would make sense to add a task w/ a final process to > > the e2e suite to avoid future breakages like this in the future? +1. Given how much time it took us to investigate, it would be imprudent to ship it without a

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Joshua Cohen
> On March 21, 2016, 7:35 p.m., Maxim Khutornenko wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 218 > > > > > > Couldn't find what it maps to in DB, is it not saved? It's done by

Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-21 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 45055: Fix flickering of the Aurora logo on refresh.

2016-03-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45055/#review124691 --- Ship it! Ship It! - Joshua Cohen On March 21, 2016, 11:17

Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45104/#review124697 --- Sorry for the delay on this. After you filed the pull request, I

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/#review124693 --- Master (c5254c7) is red with this patch.

Re: Review Request 45055: Fix flickering of the Aurora logo on refresh.

2016-03-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45055/#review124685 --- Master (c5254c7) is red with this patch.

Re: Review Request 45135: Descheduling a cron should not fail if the job is not scheduled.

2016-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45135/#review124726 ---

Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-21 Thread Pierre Cheynier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45104/ --- Review request for Aurora. Repository: aurora Description --- When

Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45104/#review124544 --- Master (b24619b) is green with this patch.

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/ --- (Updated March 21, 2016, 5:46 p.m.) Review request for Aurora, Maxim

Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45104/#review124582 --- Ship it! Ship It! - Bill Farner On March 21, 2016, 6:21

Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository:

Re: Review Request 45042: Add ACL support for announcer

2016-03-21 Thread Zameer Manji
> On March 19, 2016, 6:46 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/executor/common/announcer.py, line 128 > > > > > > please refactor to make the constructor accept the ACL list, making the > >

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124615 --- Ship it! Master (b24619b) is green with this patch.

Re: Review Request 45115: AURORA-1642: Thermos runner finalization broken.

2016-03-21 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ --- (Updated March 21, 2016, 11:36 a.m.) Review request for Aurora, Maxim

Review Request 45115: AURORA-1642: Thermos runner finalization broken.

2016-03-21 Thread Amol Deshmukh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository:

Re: Review Request 45115: AURORA-1642: Thermos runner finalization broken.

2016-03-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45115/#review124628 --- Does anyone think it would make sense to add a task w/ a final

Re: Review Request 45112: Add support for storing and fetching images as properties of task configs.

2016-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45112/#review124626 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 218)