Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125261 --- Master (9927231) is red with this patch.

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125262 --- Ship it! The ripples into the scheduler code was a little bit

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/ --- (Updated March 24, 2016, 8:52 a.m.) Review request for Aurora, David Chung,

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-24 Thread John Sirois
> On March 23, 2016, 8:31 a.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread John Sirois
> On March 23, 2016, 1:36 p.m., Zameer Manji wrote: > > I am in favor of making this change. However, it seems this patch could be > > improved because the storage layer has to now check for both `null` and > > empty collection. > > > > I think a better solution would be to change Query.Builder

Re: Review Request 45330: Remove unnecessary Map workarounds in mybatis mappers.

2016-03-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45330/#review125391 --- Master (9927231) is red with this patch.

Re: Review Request 45330: Remove unnecessary Map workarounds in mybatis mappers.

2016-03-24 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45330/#review125390 --- Ship it! Change, LGTM. Mind running the benchmarks in

Re: Review Request 45330: Remove unnecessary Map workarounds in mybatis mappers.

2016-03-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45330/#review125389 --- Ship it! Ship It! - John Sirois On March 24, 2016, 10:43

Review Request 45330: Remove unnecessary Map workarounds in mybatis mappers.

2016-03-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45330/ --- Review request for Aurora, John Sirois and Zameer Manji. Repository: aurora

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-24 Thread Zameer Manji
> On March 23, 2016, 7:31 a.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125270 --- Ship it! Master (9927231) is green with this patch.

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125265 --- @ReviewBot retry - John Sirois On March 24, 2016, 8:52 a.m.,

Re: Review Request 45193: Treat empty and null collections equivalently in task queries.

2016-03-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45193/#review125271 --- Bill - this has changed enough that you should re-assess your

Review Request 45298: Remove some dependencies linked to docker usage

2016-03-24 Thread Pierre Cheynier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45298/ --- Review request for Aurora. Repository: aurora-packaging Description ---

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-24 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45298/#review125302 --- Right now the working operation of `./build-artifact.sh` for

Re: Review Request 45298: Remove some dependencies linked to docker usage

2016-03-24 Thread John Sirois
> On March 24, 2016, 12:04 p.m., John Sirois wrote: > > Right now the working operation of `./build-artifact.sh` for consistent > > releases is paramount and use of this repo to make custom builds is > > secondary. The rpm `%setup -n ...` has gone back and forth once already > > due to

Re: Review Request 45206: HTTPLifeCycleConfig to HttpLifeCycleConfig typo

2016-03-24 Thread thinker0
Thanks John ^^; On Wed, Mar 23, 2016 at 10:01 PM John Sirois wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45206/ > > Thanks Se! I'll patch this in presently. > > > - John Sirois > > On March 23rd, 2016, 3:35 a.m. MDT,

Re: Review Request 45212: Remove hard dependency on a specific mesos-version

2016-03-24 Thread Pierre Cheynier
> On March 23, 2016, 2:31 p.m., Stephan Erb wrote: > > Thinking out loud here, so please comment: > > > > We could move to a mode where we build against a specific Mesos version, > > and recommend that version for deployment, but leave it up to the cluster > > operator to select and deploy a

Re: Review Request 45104: Use chmod+x to make termos_runner.pex executable

2016-03-24 Thread Joshua Cohen
> On March 22, 2016, 1:02 a.m., Joshua Cohen wrote: > > Sorry for the delay on this. After you filed the pull request, I > > investigated a bit what will be required once Mesos 0.30.0 lands: > > https://issues.apache.org/jira/browse/AURORA-1632. I think the problem goes > > beyond the failure