Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127098 --- Just checking my understanding here: * the ticket reads like we

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

2016-04-05 Thread Ashwin Murthy
> On April 4, 2016, 8:31 p.m., Aurora ReviewBot wrote: > > Master (9847b02) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Bill, will you be merging? Thanks! - Ashwin

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126960 --- docs/features/service-discovery.md (line 31)

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127094 --- Ship it! Ship It! - Stephan Erb On April 5, 2016, 4:53

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 3:50 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45721: thermos local-time

2016-04-05 Thread Stephan Erb
> On April 5, 2016, 4:17 a.m., John Sirois wrote: > > Do you have any thoughts on why localtime should be the winner here? > > > > Imagine these scenarios: > > You're an operator for a cluster that lives 3 timezones away > > You're an operator for 3 clusters, each in different timezones. > > >

Re: Review Request 45754: Use message provided by Mesos if present when tasks fail due to resource limit violations.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45754/#review127159 --- Ship it! Master (663d13f) is green with this patch.

Re: Review Request 45754: Use message provided by Mesos if present when tasks fail due to resource limit violations.

2016-04-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45754/#review127143 ---

Re: Review Request 45754: Use message provided by Mesos if present when tasks fail due to resource limit violations.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45754/#review127142 --- Ship it! Master (663d13f) is green with this patch.

Re: Review Request 45754: Use message provided by Mesos if present when tasks fail due to resource limit violations.

2016-04-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45754/#review127156 --- Ship it! Ship It! - Zameer Manji On April 5, 2016, 10:40

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 4:02 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 2:06 p.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will

Re: Review Request 45754: Use message provided by Mesos if present when tasks fail due to resource limit violations.

2016-04-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45754/ --- (Updated April 5, 2016, 5:40 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 45725: Remove AddInstancesConfig parameter from addInstances RPC.

2016-04-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45725/#review127163 --- Ship it! Ship It! - Zameer Manji On April 4, 2016, 7:53

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127147 --- A few drive by notes. LGTM overall.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? I used this to trigger

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 6:15 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127116 --- This patch does not apply cleanly against master (f729fd4), do

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

2016-04-05 Thread Bill Farner
> On April 4, 2016, 1:31 p.m., Aurora ReviewBot wrote: > > Master (9847b02) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" > > Ashwin Murthy wrote: > Bill, will you be

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 4:20 p.m.) Review request for Aurora, Kunal Thakar and

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127122 --- Ship it! Master (f729fd4) is green with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 1:39 p.m., Stephan Erb wrote: > > docs/features/service-discovery.md, line 31 > > > > > > How does Mesos DNS find out about our primary port? The code below > > reads like we just populate all

Review Request 45754: Use message provided by Mesos if present when tasks fail due to resource limit violations.

2016-04-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45754/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

2016-04-05 Thread Ashwin Murthy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- (Updated April 5, 2016, 9:53 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 45721: thermos local-time

2016-04-05 Thread Joshua Cohen
> On April 5, 2016, 2:17 a.m., John Sirois wrote: > > Do you have any thoughts on why localtime should be the winner here? > > > > Imagine these scenarios: > > You're an operator for a cluster that lives 3 timezones away > > You're an operator for 3 clusters, each in different timezones. > > >

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Bill Farner
> On April 5, 2016, 7:06 a.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will

Re: Review Request 45770: Slim the `ServerSet` interface.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45770/#review127204 --- Ship it! Master (5109788) is green with this patch.

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127213 --- Ship it! Mod dropping /locks endpoint. - Maxim Khutornenko

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Bill Farner
> On April 5, 2016, 7:06 a.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/ --- (Updated April 5, 2016, 2 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Maxim Khutornenko
> On April 5, 2016, 2:06 p.m., Stephan Erb wrote: > > Just checking my understanding here: > > > > * the ticket reads like we first have to deprecate the locks, and then > > remove them. This review request seems to do this in one sitting. This is > > considered ok, because thrift will

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127222 --- Ship it! Ship It! - Stephan Erb On April 5, 2016, 11

Re: Review Request 45718: Remove lock-related constructs from the API.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45718/#review127218 --- Ship it! Master (5109788) is green with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
> On April 5, 2016, 5:50 p.m., Maxim Khutornenko wrote: > > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora, line 21 > > > > > > Curious, what do changes in this file actually test? > > Zhitao Li wrote: >

Re: Review Request 45782: Adding jq to package build.sh.

2016-04-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45782/#review127245 --- Ship it! Ship It! - Maxim Khutornenko On April 5, 2016,

Re: Review Request 45779: Small Documentation fixes and nitpicks.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127235 --- Ship it! Master (5109788) is green with this patch.

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/ --- (Updated April 5, 2016, 11 p.m.) Review request for Aurora, Kunal Thakar and

Review Request 45779: Small Documentation fixes and nitpicks.

2016-04-05 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/ --- Review request for Aurora, Stephan Erb and Bill Farner. Repository: aurora

Re: Review Request 45779: Small Documentation fixes and nitpicks.

2016-04-05 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45779/#review127229 --- Ship it! Cool, thanks! I believe there is a dead link in the

Re: Review Request 45177: Setting DiscoveryInfo.

2016-04-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review127244 --- Ship it! Master (a9b3df8) is green with this patch.